Code clean up after prod backfill

[oscarAtNava]

Resolves #9594

Description

Remove some code no longer needed now that prod data is cleaned up.

Acceptance Criteria

• Code compiles correctly

Testing Plan

1. TBD

[sharonwarner]

This should be updated to always create a new HearingTask as well.

[oscarAtNava]

Do you mean to replace HearingTask.find_or_create_by!() with just HearingTask.create!()?

[sharonwarner]

Yes, that's correct!

[sharonwarner]

This looks good! Let's til Monday and confirm that all ScheduleHearingTasks and DispositionTasks have HearingTasks as parents before deploying.

[tomas-nava]

🗣 Approved!

[tomas-nava]

This PR also resolves #9538

[oscarAtNava]

@sharonwarner Almost all Disposition and ScheduleHearingTasks have a HearingTask parent. I ran the following SQL Queries to confirm and found one issue:

Total ScheduleHearingTask and DispositionTask

select count(*)
from tasks
where type IN ('DispositionTask', 'ScheduleHearingTask')

Result ==> 28,190

DispositionTask and ScheduleHearingTask with HearingTask parent

select count(*)
from tasks p, tasks c
where c.parent_id = p.id
and c.type IN ('DispositionTask', 'ScheduleHearingTask')
and p.type = 'HearingTask'

Results ==> 28,189

Appeal with issue

appeal_id = 864. It is an AMA appeal hence was not touched by my script. Appeal has a Disposition and ScheduleHearingTask with RootTask as parent.

We can fix it manually next week.

[sharonwarner]

Yes, it's fine to ignore that AMA appeal. It's already been distributed to an attorney, so we shouldn't need to do anything else.