Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data backfills | Code cleanup #9594

Closed
sharonwarner opened this issue Feb 21, 2019 · 0 comments
Closed

Data backfills | Code cleanup #9594

sharonwarner opened this issue Feb 21, 2019 · 0 comments

Comments

@sharonwarner
Copy link
Contributor

sharonwarner commented Feb 21, 2019

As we finish our data backfills, we can update our code to expect the data to be in the right state.

  1. In schedule_hearing_task.rb, we can update find_or_create_if_eligible to just find the existing ScheduleHearingTask
  2. In tasks_controller.rb, we can remove find_or_create_if_eligible from the for_appeal method
  3. In hold_hearing_task.rb, we can remove the type check on the task's parent in create_hold_hearing_task!
  4. In appeal_repository.rb, we can update create_schedule_hearing_tasks to always create a new HearingTask and a new ScheduleHearingTask
  5. In ScheduleHearingTask and DispositionTask (formerly HoldHearingTask), we can add validation such that the parent task always has to be a HearingTask
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants