Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Paula/caseflow 1126 judge tabs (#16125)" #16138

Closed
wants to merge 1 commit into from

Conversation

n1zyy
Copy link
Contributor

@n1zyy n1zyy commented Apr 16, 2021

This reverts commit 41ad80d.

Resolves #{github issue number}

Description

Please explain the changes you made here.

Acceptance Criteria

  • Code compiles correctly

Testing Plan

  1. Go to ...

User Facing Changes

  • Screenshots of UI changes added to PR & Original Issue
BEFORE AFTER

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Storybook Story

For Frontend (Presentationa) Components

  • Add a Storybook file alongside the component file (e.g. create MyComponent.stories.js alongside MyComponent.jsx)
  • Give it a title that reflects the component's location within the overall Caseflow hierarchy
  • Write a separate story (within the same file) for each discrete variation of the component

Database Changes

Only for Schema Changes

  • Timestamps (created_at, updated_at) for new tables
  • Column comments updated
  • Have your migration classes inherit from Caseflow::Migration, especially when adding indexes (use add_safe_index)
  • Verify that migrate:rollback works as desired (change supported functions)
  • Query profiling performed (eyeball Rails log, check bullet and fasterer output)
  • Appropriate indexes added (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes)
  • DB schema docs updated with make docs (after running make migrate)
  • #appeals-schema notified with summary and link to this PR
  • Any non-obvious semantics or logic useful for interpreting database data is documented at Caseflow Data Model and Dictionary

Integrations: Adding endpoints for external APIs

  • Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo
    • Request: Service name, method name, input field names
    • Response: Check expected data structure
  • Update Fakes
  • Integrations impacting functionality are tested in Caseflow UAT

@n1zyy
Copy link
Contributor Author

n1zyy commented Apr 16, 2021

For context: I did a git log to find the commit in question:

commit 41ad80db6394d96340bd50d9d723bbaff8bd25e3
Author: pbradin <[email protected]>
Date:   Fri Apr 16 10:55:33 2021 -0400
    Paula/caseflow 1126 judge tabs (#16125)

And then I ran git revert 41ad80db6394d96340bd50d9d723bbaff8bd25e3 (with the commit SHA) and pushed it up.

@n1zyy
Copy link
Contributor Author

n1zyy commented Apr 16, 2021

Calling this a dupe of #16139.

@n1zyy n1zyy closed this Apr 16, 2021
@zurbergram zurbergram deleted the mattw/revert_1126 branch March 9, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant