Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paula/caseflow 1126 judge tabs #16125

Merged
merged 15 commits into from
Apr 16, 2021
Merged

Paula/caseflow 1126 judge tabs #16125

merged 15 commits into from
Apr 16, 2021

Conversation

pbradin
Copy link
Contributor

@pbradin pbradin commented Apr 14, 2021

Resolves # 10044
Jira ticket Caseflow-1126

Description

Judges' individual queues only show a single table that is the equivalent of attorney and generic queues' "assigned" tabs. Judges can navigate to their "assign cases" view using the dropdown menu in the top right of their queue which provides a near-equivalent of the "on hold" tab. However, since judges now have the ability to assign admin actions directly to the VLJ support staff there are some on hold tasks that are not represented in the "assign cases" view.

This ticket exists to add tabs for "on hold" and "completed" tasks (in addition to the existing "assigned" table view they see now). Also confirmed that acting Judges that currently see the attorney queue tabs should continue to see the attorney queue tabs since the majority of their work is still attorney-centered activities.

Acceptance Criteria

  • Code compiles correctly
  • Judges should now see "On Hold" and "Completed" tabs when signing into queue. Of Note: Attorney version of the queue tabs displays a "Veteran Documents" link that the Judges do not have; Judge version of the queue tabs displays a "Document ID" column that the Attorney version does not have.
  • Acting judges should still see the same Attorney-version of the queue tabs.

Testing Plan

  1. Login to queue as a judge (BVAAABSHIRE)
  2. Notice that there are now 3 queue tabs under "Your cases": Assigned (which they already had), On Hold, and Completed.
  3. Notice that there is no column for "Veteran Documents" and that there is a column for "Document ID"
  4. Login to queue as an attorney (BVASCASPER1)
  5. Notice that there are also 3 tabs. No code was changed here. Just observe that there is no "Document ID" column but there is a "Veterans Documents" column for comparing with an acting VLJ.
  6. Login to queue as an acting VLJ (BVAACTING)
  7. Notice that there are also 3 tabs. Notice that the acting VLJ's columns are the same as those for an attorney.

User Facing Changes

Judge Screenshots

BEFORE
Judge Your Cases View - no tabs

AFTER
Assigned Tab
Jude Cases Assigned tab

On Hold tab
Judge Cases On Hold tab

Completed tab
Judge Cases Completed tab

####Acting VLJ Screenshot (no changes, just for reference)
Acting Judge tabs

####Attorney Screenshot (no changes, just for reference)
Attorney tabs

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

@codeclimate
Copy link

codeclimate bot commented Apr 14, 2021

Code Climate has analyzed commit bf9d992 and detected 0 issues on this pull request.

View more on Code Climate.

@pbradin pbradin changed the title WIP: Paula/caseflow 1126 judge tabs Paula/caseflow 1126 judge tabs Apr 15, 2021
app/models/user.rb Show resolved Hide resolved
spec/feature/queue/task_queue_spec.rb Show resolved Hide resolved
@pbradin pbradin added Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master Team: Echo 🐬 labels Apr 16, 2021
@va-bot va-bot merged commit 41ad80d into master Apr 16, 2021
@va-bot va-bot deleted the paula/caseflow-1126-judge-tabs branch April 16, 2021 14:55
n1zyy added a commit that referenced this pull request Apr 16, 2021
pbradin added a commit that referenced this pull request Apr 16, 2021
va-bot pushed a commit that referenced this pull request Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master Team: Echo 🐬
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tabs to judges' individual queue table views
3 participants