Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show cancelled appeals in search and list all cases #14681

Merged
merged 7 commits into from
Jul 13, 2020

Conversation

lomky
Copy link
Contributor

@lomky lomky commented Jul 10, 2020

Resolves #14221

Description

Removed the filter on Appeals Finder that filtered out Cancelled appeals.

Search results for finding appeals via File Number will now show cancelled appeals.
View All Cases on the case details page will also show cancelled appeals.

Acceptance Criteria

  • Cancelled appeals always show in search results
    • Cancelled appeals appear in search results when searching via the Veteran ID
    • Cancelled appeals appear in search results when searching via the docket ID

Testing Plan

Search

  1. Sign in as a judge or attorney & find an active appeal in your Queue
  2. Note the Veteran ID
  3. Correct Issues and mark the issues as Removed
  4. Go to search and search for the veteran ID, confirm that appeal is returned

View All Cases

  1. Sign in as a Judge and find an active appeal with multiple cases in 'View All Cases'
  2. Cancel the appeal via removal of the issues
  3. Confirm on 'View All Cases' the cancelled appeal is shown

User Facing Changes

  • Screenshots of UI changes added to PR & Original Issue
Page BEFORE AFTER
Case Details View All image image
Search Results image image

@codeclimate
Copy link

codeclimate bot commented Jul 10, 2020

Code Climate has analyzed commit 14aa336 and detected 0 issues on this pull request.

View more on Code Climate.

@lomky lomky self-assigned this Jul 10, 2020
@lomky lomky changed the title WIP Show cancelled appeals in search and list all casses Show cancelled appeals in search and list all casses Jul 10, 2020
@lomky lomky changed the title Show cancelled appeals in search and list all casses Show cancelled appeals in search and list all cases Jul 10, 2020
@@ -125,6 +125,18 @@
end
end

trait :cancelled do
after(:create) do |appeal, _evaluator|
# make sure a request issue exists, then mark all removed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find on fixing the factory!!

@va-bot
Copy link
Collaborator

va-bot commented Jul 10, 2020

1 Warning
⚠️ This PR changes the schema. Please use the PR template checklist.

Generated by 🚫 Danger

t.boolean "no_special_issues", default: false, comment: "Affirmative no special issues, added belatedly"
t.boolean "no_special_issues", default: false, comment: "Affirmative no special issues; column added belatedly"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catching a miss 😓

Copy link
Contributor

@ajspotts ajspotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lomky lomky added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Jul 13, 2020
@va-bot va-bot merged commit dc3ee83 into master Jul 13, 2020
@va-bot va-bot deleted the kat/14221_cancelled_appeals_in_search branch July 13, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searching for a Veteran's appeals using Veteran ID should display cancelled appeals
4 participants