Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searching for a Veteran's appeals using Veteran ID should display cancelled appeals #14221

Closed
3 tasks
araposo-tistatech opened this issue May 7, 2020 · 2 comments · Fixed by #14681
Closed
3 tasks

Searching for a Veteran's appeals using Veteran ID should display cancelled appeals #14221

araposo-tistatech opened this issue May 7, 2020 · 2 comments · Fixed by #14681
Assignees
@lomky
Labels
Feature: caseflow-search /search decision reviews Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Bug Type: Investigation
Milestone
PI4-S6: Sea of Tr...

Comments

@araposo-tistatech
Copy link

araposo-tistatech commented May 7, 2020 •
edited by lomky
Loading

Description

When a user searches for a Veterans cases using their Veteran ID and not the docket ID, etc. the cancelled appeal should still display in the search results.

Acceptance criteria

  • Cancelled appeals always show in search results
    • Cancelled appeals appear in search results when searching via the Veteran ID
    • Cancelled appeals appear in search results when searching via the docket ID

Background/context/resources

https://appeals.cf.ds.va.gov/queue/appeals/5a3c20c5-eb38-42ac-9278-ac600f94d4ec - Completely disappeared from Caseflow after it was deleted. (I looked into this myself and I want to specify that the user is searching using the Veterans ID and the deleted appeal does not display in the cases found list)

https://appeals.cf.ds.va.gov/search?veteran_ids=421632 - Deleted appeal (cancelled one) is not displaying in search results.

Technical notes
@araposo-tistatech araposo-tistatech added Product: caseflow-queue Type: Bug Team: Echo 🐬 Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. labels May 7, 2020
@hschallhorn hschallhorn added Type: Investigation Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Feature: caseflow-search /search decision reviews labels May 14, 2020
@lomky lomky changed the title Searching for a Veterans appeals using Veteran ID does not display cancelled appeals Searching for a Veteran's appeals using Veteran ID should display cancelled appeals May 14, 2020
@lomky
Copy link
Contributor

lomky commented May 14, 2020

what is this chart?

1 | |
2 | ||||||||
3 | |||
5 | 
8 |

Why 1?

  • might just be changing a scope or query

Why 2?

  • Wariness

Why 3?

  • Seems like it could be a specific issue with these appeals and not a caseflow related bug (editing vet data in vacols, etc.)

@hschallhorn hschallhorn mentioned this issue Jun 29, 2020
Closed
@lomky lomky self-assigned this Jul 7, 2020
@lomky lomky mentioned this issue Jul 10, 2020
Merged
4 tasks
@lomky
Copy link
Contributor

lomky commented Jul 13, 2020

Implemented as requested for Appeals - no affect on other Decision Reviews!

va-bot pushed a commit that referenced this issue Jul 13, 2020
@lomky
Show cancelled appeals in search and list all cases (#14681)
dc3ee83 
Resolves #14221 

### Description
Removed the filter on Appeals Finder that filtered out Cancelled appeals. 

Search results for finding appeals via File Number will now show cancelled appeals. 
View All Cases on the case details page will also show cancelled appeals.

### Acceptance Criteria
- [x] Cancelled appeals always show in search results
  - [x] Cancelled appeals appear in search results when searching via the Veteran ID 
  - [x] Cancelled appeals appear in search results when searching via the docket ID

### Testing Plan
Search
1. Sign in as a judge or attorney & find an active appeal in your Queue
2. Note the Veteran ID
3. Correct Issues and mark the issues as Removed
4. Go to search and search for the veteran ID, confirm that appeal is returned

View All Cases
1. Sign in as a Judge and find an active appeal with multiple cases in 'View All Cases'
2. Cancel the appeal via removal of the issues
3. Confirm on 'View All Cases' the cancelled appeal is shown

### User Facing Changes
 - [x] Screenshots of UI changes added to PR & Original Issue

Page | BEFORE|AFTER
---|---|---
Case Details View All | ![image](https://user-images.githubusercontent.com/6129479/87164563-e9b41e80-c296-11ea-9fab-79eeb0532dbd.png) | ![image](https://user-images.githubusercontent.com/6129479/87164710-18ca9000-c297-11ea-9070-56c032ab2dc0.png)
Search Results | ![image](https://user-images.githubusercontent.com/6129479/87164598-f6d10d80-c296-11ea-81bf-eef1c588aeb4.png) | ![image](https://user-images.githubusercontent.com/6129479/87164682-0fd9be80-c297-11ea-9b56-bede2ec10573.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lomky lomky

Labels
Feature: caseflow-search /search decision reviews Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Bug Type: Investigation
Projects
None yet
Milestone
PI4-S6: Sea of Tranquility Sprint
Development

Successfully merging a pull request may close this issue.

Show cancelled appeals in search and list all cases department-of-veterans-affairs/caseflow
3 participants
@lomky @hschallhorn @araposo-tistatech