Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 508 coding to queue table #14513

Merged
merged 16 commits into from
Aug 17, 2020
Merged

Add 508 coding to queue table #14513

merged 16 commits into from
Aug 17, 2020

Conversation

sahalliburton
Copy link
Contributor

Resolves #12094

Description

Previously the QueueTable component was not coded to assistive technology as it was missing many of the labels required by these applications to work. This PR updates the table to include the correct coding as well as adds storybook stories and jest tests for the component

Acceptance Criteria

  • Code compiles correctly

Storybook Story

For Frontend (Presentationa) Components

  • Add a Storybook file alongside the component file (e.g. create MyComponent.stories.js alongside MyComponent.jsx)
  • Give it a title that reflects the component's location within the overall Caseflow hierarchy
  • Write a separate story (within the same file) for each discrete variation of the component

@va-bot
Copy link
Collaborator

va-bot commented Jun 11, 2020 •
edited
Loading

2 Warnings
⚠️ This is a Big PR. Try to break this down if possible. Stacked pull requests encourage more detailed and thorough code reviews
⚠️ This PR modifies React components — consider adding/updating corresponding Storybook file

Generated by 🚫 Danger

@codeclimate
Copy link

codeclimate bot commented Jun 11, 2020 •
edited
Loading

Code Climate has analyzed commit c366304 and detected 0 issues on this pull request.

View more on Code Climate.

@rubaiyat22 rubaiyat22 self-assigned this Jun 11, 2020
@chandracarney chandracarney mentioned this pull request Jun 17, 2020
Closed
rubaiyat22
rubaiyat22 reviewed Jun 17, 2020
View reviewed changes
Copy link

@rubaiyat22 rubaiyat22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomas-nava tomas-nava self-assigned this Aug 14, 2020
sahalliburton
sahalliburton commented Aug 14, 2020
View reviewed changes
client/app/queue/QueueTable.jsx
@@ -15,6 +15,7 @@ import ApiUtil from '../util/ApiUtil';
import LoadingScreen from '../components/LoadingScreen';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just exports components/functions to be tested by jest

tomas-nava
tomas-nava approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@tomas-nava tomas-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve!

@sahalliburton sahalliburton added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Aug 17, 2020
@va-bot va-bot merged commit 105d695 into master Aug 17, 2020
@va-bot va-bot deleted the shalliburton/12094-queue-table-headers branch August 17, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-nava tomas-nava tomas-nava approved these changes

@rubaiyat22 rubaiyat22 rubaiyat22 approved these changes

Assignees

@rubaiyat22 rubaiyat22

@tomas-nava tomas-nava

Labels
Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Queue table headers not being read by screen reader
4 participants
@sahalliburton @va-bot @rubaiyat22 @tomas-nava