Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue: When a column has a filter applied, AT does not read to users that a filter is applied. #12134

Closed
alisan16 opened this issue Sep 17, 2019 · 15 comments · Fixed by #13049
Closed
Assignees
Labels
blocked This is blocked Feature: queue-table-view Priority: High Escalations from Support, blocking issue/NO workaround, or "first in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Accessibility Related to Accessibility support (Section 508)

Comments

@alisan16
Copy link
Contributor

The state of the Filter elements Task, Types and Docket is not read by assistive technology programs. If a filter is applied, visually a user can see this change has been applied to the data, however this change is not read by assistive technology programs. It should read "Column_name filtered by filter_criteria". (New: 08/21/2019) in caseflowdemo (under Queue/your queue/assigned)

@lowellrex
Copy link
Contributor

image

Is the issue here that the "Filtering by: Case Type (1)" text is not being read, or that when the "Type(s)" column heading is read, there is no indication that a filter has been applied?

@alisan16
Copy link
Contributor Author

I believe it is the latter, that when the column heading is read, the state of the filter isn't being described. There was also an open question of whether the filter itself could be applied using keyboard navigation (primarily tab, and ctrl+alt+arrow within a table). cc @carodew

This was the description provided to us:

"The state of the Filter elements Task, Types and Docket is not read by assistive technology programs. If a filter is applied, visually a user can see this change has been applied to the data, however this change is not read by assistive technology programs. (New: 08/21/2019) in caseflowdemo (under Queue/your queue/assigned) – I couldn’t get it to function in Chrome"
Screen Shot 2019-10-17 at 10 48 38 AM

@alisan16 alisan16 added the Type: Accessibility Related to Accessibility support (Section 508) label Dec 4, 2019
@hschallhorn hschallhorn self-assigned this Dec 20, 2019
@hschallhorn
Copy link
Contributor

@alisan16 What should we return for multiple filter selections? Should we add "and"s in between? Build a grammatically correct list? What's your take on the oxford comma?

@alisan16
Copy link
Contributor Author

Completely up to you! Either of those options sounds good to me.

va-bot pushed a commit that referenced this issue Jan 10, 2020
)

Resolves #12134

### Description
Ensures screen readers will read what a column is filtered by

### Acceptance Criteria
- [ ] When no filters are selected only the column name is read
- [ ] When filters are applied, "Column_name filtered by filter_criteria" is read

### Testing Plan
1. Go to any queue with multiple filter options, I chose BVAAAAAAAAABSHIRE's assign queue http://localhost:3000/queue/3/assign
1. Use voice over to navigate to the Task(s) column filter Icon
1. Ensure this reads "Filter by type"
1. Apply "Original" filter
1. Use voice over to navigate back to the Task(s) column filter Icon
1. Ensure this reads "Filter by type. Filtered by original"
1. Apply "Post Remand" filter as well
1. Use voice over to navigate back to the Task(s) column filter Icon
1. Ensure this reads "Filter by type. Filtered by original, post remand"
@araposo-tistatech
Copy link

reopening as this has not been resolved per the latest audit:

"I couldn’t get it to function in Chrome (3/26/2020 I was able to get to the filter but it was not read by JAWs once I activated (checked the box) of a filter)"

@hschallhorn hschallhorn removed their assignment May 20, 2020
@hschallhorn hschallhorn added Priority: High Escalations from Support, blocking issue/NO workaround, or "first in" priority for new work. Feature: queue-table-view Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests labels May 20, 2020
@ajspotts ajspotts self-assigned this Jun 11, 2020
@ajspotts
Copy link
Contributor

@araposo-tistatech Using Chrome, JAWS was able to successfully read the filter option. In the screenshot you can see the red box (which is indicative of JAWS focus) highlighting the filter.

Screen Shot 2020-06-16 at 10 43 02 AM

@araposo-tistatech
Copy link

@chandracarney please see Alec's note above and advise how we should move forward. We are unable to replicate the issue.

@carodew
Copy link
Contributor

carodew commented Jun 16, 2020

I think what this is saying is that when a filter is currently in effect that the screen reader should announce what filter is applied when the header cell for that column receives focus, so that the user knows that there is a filter applied (versus the table showing all data). Worth confirming with Linsey, though.

@ajspotts
Copy link
Contributor

I believe there are 2 separate issues, 1 from the original audit (listed in Alisa's issue description) and then the issue that Ann-Marie mentioned from the most recent audit when she re-opened this issue. Alisa's issue describing the problem with the column header was taken care of in a PR from Hunter. Ann-Marie's issue from the newer audit (filter not read by JAWS when activated) is what I was referencing. Hope that provides some clarity instead of more confusion! I'm adding the full description of the original and updated issues from the Caseflow a11y issues doc:

The state of the Filter elements Task, Types and Docket is not read by assistive technology programs. If a filter is applied, visually a user can see this change has been applied to the data, however this change is not read by assistive technology programs. (New: 08/21/2019) in caseflowdemo (under Queue/your queue/assigned) – I couldn’t get it to function in Chrome (3/26/2020 I was able to get to the filter but it was not read by JAWs once I activated (checked the box) of a filter)

@chandracarney
Copy link

@ajspotts Thanks for checking in! I haven't had a chance to test this out on my own, but I do wonder if this part was taken care of by @sahalliburton's recent changes in #14513? Though not yet merged, I know there was a big overhaul of how tables work for screen readers.

If not, I am happy to 1) make some time to test myself to understand behavior, and 2) check in with Linsey for more context or and test if this has been resolved.

@alisan16
Copy link
Contributor Author

Potential duplicate of #12902, blocked until we get further confirmation from Section 508

@alisan16 alisan16 added the blocked This is blocked label Jun 17, 2020
@ajspotts
Copy link
Contributor

Potential duplicate of #12902, blocked until we get further confirmation from Section 508

@alisan16 @jimruggiero I see that we've closed the other issue that was also awaiting confirmation. Do we know if we can go ahead and close this one as well?

@jimruggiero
Copy link

jimruggiero commented Jun 25, 2020 via email

@araposo-tistatech
Copy link

@ajspotts Lindsey has confirmed that this is not a duplicate. In this case the state needs to be read that a filter is applied for 12902 the issue is about being accessible via the keyboard.

@ajspotts
Copy link
Contributor

ajspotts commented Jul 9, 2020

Closing after confirming with @araposo-tistatech during JAWS testing walkthrough that the filter options are correctly being announced

@ajspotts ajspotts closed this as completed Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This is blocked Feature: queue-table-view Priority: High Escalations from Support, blocking issue/NO workaround, or "first in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Accessibility Related to Accessibility support (Section 508)
Projects
None yet
8 participants