[PART 3] Remove assignee_label from cached appeals #14265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 13, 2020
hschallhorn
commented
May 13, 2020
Generated by 🚫 Danger |
pkarman
suggested changes
May 13, 2020
yoomlam
approved these changes
May 13, 2020
Comment on lines
+3
to
+5
| safety_assured do | ||
| remove_column :cached_appeal_attributes, :assignee_label, :string, comment: "Queues will now use the actual task assignee rather than the appeal's assigned to location" | ||
| end |
There was a problem hiding this comment.
Do we need to do this in steps as described here, i.e., ignore, deploy, then migrate? Or is it because this is a cache so we're not as concerned about its integrity?
There was a problem hiding this comment.
Yeah, as we're never really relying on this information anywhere, only joins-ing the table to get extra information.
hschallhorn
merged commit 63ee763
into
hschallhorn/13914-use-assignee-name-in-queue-part-2
hschallhorn
deleted the
hschallhorn/13914-use-assignee-name-in-queue-part-3
branch
hschallhorn
added a commit
that referenced
this pull request
May 18, 2020
* Show task assignee name in queue tables * SQL resuffling * Use css_id over full_name * [PART 3] Remove assignee_label from cached appeals (#14265) * Remove assignee_label from cached appeals * ETL migrations before running make docs!
va-bot
pushed a commit
that referenced
this pull request
May 18, 2020
…14263) # THIS PR Resolves #13914 PART 1 of the stack PART 2 #14264 PART 3 #14265 ### Description Moves `joins(CachedAppeal.left_join_from_tasks_clause)` into a scope on tasks ### Acceptance Criteria - [x] Tests pass (no changes) # FULL STACK ### Description Rather than displaying an appeal's problematic assigned_to_location, show the actual task assignee in task tables. ### Acceptance Criteria - [ ] Task tables display the name of the org or the name of the user that is assigned the task - [ ] Organization queues - [ ] Can sort by assignee name - [ ] Can filter by assignee name - [ ] Show the correct assignee filter options ### Testing Plan #### Tasks assigned to users 1. Sign in as BVALSPORER 1. Navigate to the VLJ support queue http://localhost:3000/organizations/vlj-support 1. Confirm that assignee css_ids appear in the queue table 1. Confirm filter options look correct 1. Confirm filtering works 1. Confirm sorting works #### Tasks assigned to organizations 1. Sign in as Jolly Postman 1. Navigate to any ama case (I searched for vet 321321321) and add 4 tasks (FOIA, AOD, change of addrress, and Congressional Interest) 1. Update all these tasks to be on hold ```ruby uuid = "" appeal = Appeal.find_by_uuid(uuid) MailTask.where(appeal: appeal).each(&:on_hold!) appeal.reload.treee ┌──────────────────────────────────────────────────────────────────────────────┐ Appeal 138 (direct_review) ────────────────── │ ID │ STATUS │ ASGN_BY │ ASGN_TO │ UPDATED_AT │ └── RootTask │ 352 │ on_hold │ │ Bva │ 2020-05-07 16:00:44 UTC │ ├── DistributionTask │ 353 │ on_hold │ │ Bva │ 2020-05-13 00:46:14 UTC │ │ ├── CongressionalInterestMailTask │ 2623 │ on_hold │ │ MailTeam │ 2020-05-13 00:46:14 UTC │ │ │ └── CongressionalInterestMailTask │ 2624 │ on_hold │ JOLLY_POSTMAN │ LitigationSupport │ 2020-05-13 00:47:38 UTC │ │ └── FoiaRequestMailTask │ 2625 │ on_hold │ │ MailTeam │ 2020-05-13 00:46:22 UTC │ │ └── FoiaRequestMailTask │ 2626 │ on_hold │ JOLLY_POSTMAN │ PrivacyTeam │ 2020-05-13 00:47:38 UTC │ ├── AodMotionMailTask │ 2627 │ on_hold │ │ MailTeam │ 2020-05-13 00:46:35 UTC │ │ └── AodMotionMailTask │ 2628 │ on_hold │ JOLLY_POSTMAN │ AodTeam │ 2020-05-13 00:47:38 UTC │ └── AddressChangeMailTask │ 2629 │ on_hold │ │ MailTeam │ 2020-05-13 00:47:00 UTC │ └── AddressChangeMailTask │ 2630 │ on_hold │ JOLLY_POSTMAN │ Colocated │ 2020-05-13 00:47:00 UTC │ └── AddressChangeMailTask │ 2631 │ on_hold │ JOLLY_POSTMAN │ BVALSPORER │ 2020-05-13 00:47:38 UTC │ └──────────────────────────────────────────────────────────────────────────────┘ ``` 1. Go to the mail queue's on hold tab http://localhost:3000/organizations/mail?tab=on_hold 1. Confirm that assignee org names appear in the queue table 1. Confirm filter options look correct 1. Confirm filtering works 1. Confirm sorting works ### User Facing Changes - [x] Queues show the actual assignees of each task (no one assignee for all tasks for one case) BEFORE|AFTER ---|--- | - [x] Queues show the css_id of the user assignee, rather than a mix of user id or css_id? BEFORE|AFTER ---|--- |<img width="973" alt="Screen Shot 2020-05-15 at 1 25 39 PM" src="https://user-images.githubusercontent.com/45575454/82078744-a7fc6280-96af-11ea-9e70-a0897a1dd51a.png"> - [x] Queues do not show "Case Storage" unless they are actually assigned to BVA BEFORE|AFTER ---|--- |<img width="1024" alt="Screen Shot 2020-05-15 at 5 02 39 PM" src="https://user-images.githubusercontent.com/45575454/82095870-ebfe6000-96cd-11ea-8c1d-a0355f150698.png">
|
|<img){kind=link}
|<img){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps #13914
PART 3 of stack
PART 1 #14263
PART 2 #14264
Description
Removes assignee_label from cached appeals attributes table as it is no longer used
Acceptance Criteria
UpdateCachedAppealsAttributesJobstill runs correctlyTesting Plan
UpdateCachedAppealsAttributesJobDatabase Changes
make docs