-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PART 2] Show task assignee name in queue tables #14264
Merged
hschallhorn
merged 5 commits into
hschallhorn/13914-use-assignee-name-in-queue-part-1
from
hschallhorn/13914-use-assignee-name-in-queue-part-2
May 18, 2020
Merged
[PART 2] Show task assignee name in queue tables #14264
hschallhorn
merged 5 commits into
hschallhorn/13914-use-assignee-name-in-queue-part-1
from
hschallhorn/13914-use-assignee-name-in-queue-part-2
May 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
hschallhorn
commented
May 13, 2020
hschallhorn
commented
May 13, 2020
hschallhorn
commented
May 13, 2020
hschallhorn
commented
May 13, 2020
hschallhorn
commented
May 13, 2020
hschallhorn
commented
May 13, 2020
hschallhorn
commented
May 13, 2020
hschallhorn
commented
May 13, 2020
hschallhorn
commented
May 13, 2020
hschallhorn
commented
May 13, 2020
hschallhorn
commented
May 13, 2020
hschallhorn
commented
May 13, 2020
hschallhorn
commented
May 13, 2020
hschallhorn
commented
May 13, 2020
hschallhorn
commented
May 13, 2020
6 tasks
1 task
hschallhorn
commented
May 15, 2020
hschallhorn
commented
May 15, 2020
hschallhorn
commented
May 15, 2020
ajspotts
approved these changes
May 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 🚀
* Remove assignee_label from cached appeals * ETL migrations before running make docs!
hschallhorn
merged commit May 18, 2020
b49e828
into
hschallhorn/13914-use-assignee-name-in-queue-part-1
hschallhorn
deleted the
hschallhorn/13914-use-assignee-name-in-queue-part-2
branch
May 18, 2020 13:59
va-bot
pushed a commit
that referenced
this pull request
May 18, 2020
…14263) # THIS PR Resolves #13914 PART 1 of the stack PART 2 #14264 PART 3 #14265 ### Description Moves `joins(CachedAppeal.left_join_from_tasks_clause)` into a scope on tasks ### Acceptance Criteria - [x] Tests pass (no changes) # FULL STACK ### Description Rather than displaying an appeal's problematic assigned_to_location, show the actual task assignee in task tables. ### Acceptance Criteria - [ ] Task tables display the name of the org or the name of the user that is assigned the task - [ ] Organization queues - [ ] Can sort by assignee name - [ ] Can filter by assignee name - [ ] Show the correct assignee filter options ### Testing Plan #### Tasks assigned to users 1. Sign in as BVALSPORER 1. Navigate to the VLJ support queue http://localhost:3000/organizations/vlj-support 1. Confirm that assignee css_ids appear in the queue table 1. Confirm filter options look correct 1. Confirm filtering works 1. Confirm sorting works #### Tasks assigned to organizations 1. Sign in as Jolly Postman 1. Navigate to any ama case (I searched for vet 321321321) and add 4 tasks (FOIA, AOD, change of addrress, and Congressional Interest) 1. Update all these tasks to be on hold ```ruby uuid = "" appeal = Appeal.find_by_uuid(uuid) MailTask.where(appeal: appeal).each(&:on_hold!) appeal.reload.treee ┌──────────────────────────────────────────────────────────────────────────────┐ Appeal 138 (direct_review) ────────────────── │ ID │ STATUS │ ASGN_BY │ ASGN_TO │ UPDATED_AT │ └── RootTask │ 352 │ on_hold │ │ Bva │ 2020-05-07 16:00:44 UTC │ ├── DistributionTask │ 353 │ on_hold │ │ Bva │ 2020-05-13 00:46:14 UTC │ │ ├── CongressionalInterestMailTask │ 2623 │ on_hold │ │ MailTeam │ 2020-05-13 00:46:14 UTC │ │ │ └── CongressionalInterestMailTask │ 2624 │ on_hold │ JOLLY_POSTMAN │ LitigationSupport │ 2020-05-13 00:47:38 UTC │ │ └── FoiaRequestMailTask │ 2625 │ on_hold │ │ MailTeam │ 2020-05-13 00:46:22 UTC │ │ └── FoiaRequestMailTask │ 2626 │ on_hold │ JOLLY_POSTMAN │ PrivacyTeam │ 2020-05-13 00:47:38 UTC │ ├── AodMotionMailTask │ 2627 │ on_hold │ │ MailTeam │ 2020-05-13 00:46:35 UTC │ │ └── AodMotionMailTask │ 2628 │ on_hold │ JOLLY_POSTMAN │ AodTeam │ 2020-05-13 00:47:38 UTC │ └── AddressChangeMailTask │ 2629 │ on_hold │ │ MailTeam │ 2020-05-13 00:47:00 UTC │ └── AddressChangeMailTask │ 2630 │ on_hold │ JOLLY_POSTMAN │ Colocated │ 2020-05-13 00:47:00 UTC │ └── AddressChangeMailTask │ 2631 │ on_hold │ JOLLY_POSTMAN │ BVALSPORER │ 2020-05-13 00:47:38 UTC │ └──────────────────────────────────────────────────────────────────────────────┘ ``` 1. Go to the mail queue's on hold tab http://localhost:3000/organizations/mail?tab=on_hold 1. Confirm that assignee org names appear in the queue table 1. Confirm filter options look correct 1. Confirm filtering works 1. Confirm sorting works ### User Facing Changes - [x] Queues show the actual assignees of each task (no one assignee for all tasks for one case) BEFORE|AFTER ---|--- ![Screen Shot 2020-05-12 at 8 53 39 PM](https://user-images.githubusercontent.com/45575454/81759614-2d56fb80-9493-11ea-9969-35b8a5ba09ff.png)|![Screen Shot 2020-05-12 at 8 52 41 PM](https://user-images.githubusercontent.com/45575454/81759607-292ade00-9493-11ea-984e-54edd4265aa5.png) - [x] Queues show the css_id of the user assignee, rather than a mix of user id or css_id? BEFORE|AFTER ---|--- ![Screen Shot 2020-05-12 at 8 55 59 PM](https://user-images.githubusercontent.com/45575454/81759681-5e373080-9493-11ea-958b-b6e9e79e773e.png)|<img width="973" alt="Screen Shot 2020-05-15 at 1 25 39 PM" src="https://user-images.githubusercontent.com/45575454/82078744-a7fc6280-96af-11ea-9e70-a0897a1dd51a.png"> - [x] Queues do not show "Case Storage" unless they are actually assigned to BVA BEFORE|AFTER ---|--- ![Screen Shot 2020-05-12 at 9 00 31 PM](https://user-images.githubusercontent.com/45575454/81759811-b66e3280-9493-11ea-8e1c-737a69757bb8.png)|<img width="1024" alt="Screen Shot 2020-05-15 at 5 02 39 PM" src="https://user-images.githubusercontent.com/45575454/82095870-ebfe6000-96cd-11ea-8c1d-a0355f150698.png">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps #13914
PART 2 of stack
PART 1 #14263
PART 3 #14265
Description
Rather than displaying an appeal's problematic assigned_to_location, show the actual task assignee in task tables.
Acceptance Criteria
Testing Plan
Tasks assigned to users
Tasks assigned to organizations
User Facing Changes