Enable pagination for all organizations #13824
Conversation
| @@ -61,7 +61,7 @@ def show_reader_link_column? | |||
| end | |||
|
|
|||
| def use_task_pages_api? | |||
| false | |||
| true | |||
There was a problem hiding this comment.
Heart of the change. The rest is just removing unused code and fixing tests
| def tabs | ||
| queue_tabs = assignee.queue_tabs | ||
|
|
||
| return queue_tabs unless !assignee.use_task_pages_api? && assignee_is_org? |
There was a problem hiding this comment.
Was used to handle any orgs that did not use pagination. None of those exist anymore.
|
Code Climate has analyzed commit b394a33 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Generated by 🚫 Danger |
| @@ -59,19 +59,18 @@ class OrganizationQueue extends React.PureComponent { | |||
| return config; | |||
There was a problem hiding this comment.
All changes in OrganizationQueue.jsx are due to config.use_task_pages_api returning true for all orgs
| @@ -445,341 +447,230 @@ def validate_pulac_cerullo_tasks_created(task_class, label) | |||
| before do | |||
| organization.add_user(organization_user) | |||
| User.authenticate!(user: organization_user) | |||
| end | |||
There was a problem hiding this comment.
View without whitespace changes if need be. Removed "when not using pagination" as pagination should always be enabled
| @@ -222,34 +222,6 @@ | |||
| end | |||
| end | |||
|
|
|||
| describe ".use_task_pages_api?" do | |||
There was a problem hiding this comment.
Always returns true
| @@ -88,7 +88,7 @@ | |||
|
|
|||
| context "with a non-VSO organization assignee" do | |||
| it "does not include a tab for tracking tasks" do | |||
| expect(subject.length).to eq(3) | |||
| expect(subject.length).to eq(4) | |||
There was a problem hiding this comment.
All orgs now also have the "on hold tab" see: https://github.com/department-of-veterans-affairs/caseflow/pull/13824/files#diff-0e38eeb126d1e7d54ae84ff58a647e0cL41
hschallhorn
added
the
Ready-to-Merge
### Description Removes selectors that are unused as of #13824. ### Acceptance Criteria - [ ] No unused selectors in the code
Resolves #13714
Description
Enables pagination for every organization and removes unused code
UI Changes
This only applies to organizations that did not have pagination.
Queue tabs
Assigned tasks
Tasks in the assigned tab will now show how long the task has been waiting at the assigned user. Example below of a task that was created for the translation team 29 days ago and assigned to a team member today.
Before
After
Deep links
The URL will update as the user selects a new tab, sort column, sort order, or filters. This link can be bookmarked or saved to return to that same sorted and filtered set of tasks.