Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve load times for organizations/privacy/tasks #13714

Closed
1 task
yoomlam opened this issue Mar 16, 2020 · 2 comments · Fixed by #13824
Closed
1 task

Improve load times for organizations/privacy/tasks #13714

yoomlam opened this issue Mar 16, 2020 · 2 comments · Fixed by #13824
Labels
Priority: High Escalations from Support, blocking issue/NO workaround, or "first in" priority for new work. Product: caseflow-queue Source: Sentry Alert created because of a Sentry alert Team: Echo 🐬
Milestone
PI3-S5: Sandra Da...

Comments

@yoomlam
Copy link
Contributor

yoomlam commented Mar 16, 2020 •
edited by hschallhorn
Loading

Description

As bvajretan, the page at https://appeals.cf.ds.va.gov/organizations/privacy took 1.2 mins to transfer 2.1 MB to load 298 unassigned cases, 208 assigned cases, and 50 completed cases.
The endpoint that takes a long time is organizations/privacy/tasks.

From Hunter:

Privacy team does not have pagination enabled. Only the colocated team, hearings management, and all VSOs use pagination.

Acceptance criteria

  • Reduced load times

Background/context/resources

Technical notes
@yoomlam yoomlam added Product: caseflow-queue Team: Echo 🐬 Source: Sentry Alert created because of a Sentry alert Priority: Low Reported issue, not a blocker. "Last in" priority for new work. labels Mar 16, 2020
@yoomlam
Copy link
Contributor Author

yoomlam commented Mar 19, 2020

what is this chart?

1 | ||
2 | ||||||
3 | ||
5 | 
8 |

Need Board buy-in. Does BVA like pagination?
Should we enable for everyone?

Pagination only enabled for certain teams: ColocatedTeam, VSO, PrivacyTeam, etc...

Why 1?

  • Change false to true in organization.rb use_task_pages_api?

Why 2?

  • Ramp up on pagination
  • Refactor existing to use pagination

Why 3?

  • Learning curve

@yoomlam
Copy link
Contributor Author

yoomlam commented Mar 19, 2020

Related #10170

@hschallhorn hschallhorn mentioned this issue Mar 20, 2020
Closed
@hschallhorn hschallhorn mentioned this issue Mar 30, 2020
Merged
@hschallhorn hschallhorn added Priority: High Escalations from Support, blocking issue/NO workaround, or "first in" priority for new work. and removed Priority: Low Reported issue, not a blocker. "Last in" priority for new work. labels Mar 30, 2020
@hschallhorn hschallhorn mentioned this issue Mar 30, 2020
Closed
va-bot pushed a commit that referenced this issue Apr 1, 2020
@hschallhorn
Enable pagination for all organizations (#13824)
4a1fd3c 
Resolves #13714

### Description
Enables pagination for every organization and removes unused code

### UI Changes
This only applies to organizations that did not have pagination.

#### Queue tabs
Tab Name|Description|Before|After|Change
---|---|---|---|---
Unassigned|Tasks that have not been assigned to a member of the organization|![Screen Shot 2020-03-30 at 12 41 11 PM](https://user-images.githubusercontent.com/45575454/77938685-17df9680-7284-11ea-8bbd-ee6ef0c4a713.png)|![Screen Shot 2020-03-30 at 12 40 03 PM](https://user-images.githubusercontent.com/45575454/77938743-2b8afd00-7284-11ea-9ef1-05f221f4ecf5.png)|NONE
Assigned|Tasks that have been assigned to a member of the organization|![Screen Shot 2020-03-30 at 12 41 19 PM](https://user-images.githubusercontent.com/45575454/77938808-42c9ea80-7284-11ea-8c4e-1edbdb43b791.png)|![Screen Shot 2020-03-30 at 12 40 11 PM](https://user-images.githubusercontent.com/45575454/77938819-48273500-7284-11ea-8913-55fd8910284b.png)|Tasks that have been assigned and are now on hold are moved to the on hold tab
On hold|Tasks that have been assigned to a member of the organization and are now on hold| NONE |![Screen Shot 2020-03-30 at 12 40 18 PM](https://user-images.githubusercontent.com/45575454/77938920-7147c580-7284-11ea-8d43-fca13c62dcfb.png)|New tab!
Completed|Tasks that have been completed in the last 2 weeks|![Screen Shot 2020-03-30 at 12 46 53 PM](https://user-images.githubusercontent.com/45575454/77939087-9dfbdd00-7284-11ea-9820-7a23b663db51.png)|![Screen Shot 2020-03-30 at 12 47 15 PM](https://user-images.githubusercontent.com/45575454/77939100-a2c09100-7284-11ea-91e9-8eef0bc2128b.png)|NONE

#### Assigned tasks
Tasks in the assigned tab will now show how long the task has been waiting at the assigned user. Example below of a task that was created for the translation team 29 days ago and assigned to a team member today.

**Before**
![Screen Shot 2020-03-30 at 12 41 19 PM](https://user-images.githubusercontent.com/45575454/77939732-9ab52100-7285-11ea-8e48-60ebfc10d2a6.png)
**After**
![Screen Shot 2020-03-30 at 12 40 11 PM](https://user-images.githubusercontent.com/45575454/77939748-a1439880-7285-11ea-88a0-b509685d2327.png)

#### Deep links

The URL will update as the user selects a new tab, sort column, sort order, or filters. This link can be bookmarked or saved to return to that same sorted and filtered set of tasks.

![ezgif-3-517b4efbb032](https://user-images.githubusercontent.com/45575454/78140388-eee01280-73f7-11ea-84a8-8b0e2c923aed.gif)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: High Escalations from Support, blocking issue/NO workaround, or "first in" priority for new work. Product: caseflow-queue Source: Sentry Alert created because of a Sentry alert Team: Echo 🐬
Projects
None yet
Milestone
PI3-S5: Sandra Day O’Connor Sprint
Development

Successfully merging a pull request may close this issue.

Enable pagination for all organizations department-of-veterans-affairs/caseflow
3 participants
@hschallhorn @jimruggiero @yoomlam