Create Vacated Decision Issues from Request Issues

app/controllers/post_decision_motions_controller.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class PostDecisionMotionsController < ApplicationController
-  before_action :verify_task_access
+  before_action :verify_task_access, only: [:create, :return_to_lit_support]
 
   def create
     motion_updater = PostDecisionMotionUpdater.new(task, motion_params)
@@ -40,4 +40,8 @@ def task
   def motion_params
     params.permit(:disposition, :task_id, :vacate_type, :instructions, :assigned_to_id, vacated_decision_issue_ids: [])
   end
+
+  def post_decision_motion
+    PostDecisionMotion.find(motion_id)
+  end
 end

app/models/decision_issue.rb

@@ -160,8 +160,9 @@ def associated_request_issue
   end
 
   def create_contesting_request_issue!
-    RequestIssue.create!(
-      decision_review: decision_review,
+    vacate_appeal_stream = Appeal.find_by(stream_type: "vacate", stream_docket_number: decision_review.docket_number)
+    RequestIssue.find_or_create_by!(
+      decision_review: vacate_appeal_stream,
       decision_review_type: decision_review_type,
       contested_decision_issue_id: id,
       contested_rating_issue_reference_id: rating_issue_reference_id,

app/models/post_decision_motion.rb

@@ -21,14 +21,26 @@ class PostDecisionMotion < ApplicationRecord
     vacate_and_de_novo: "vacate_and_de_novo"
   }
 
-  def vacated_issues
+  def decision_issues_for_vacatur
     return [] unless vacated_decision_issue_ids
 
     DecisionIssue.find(vacated_decision_issue_ids)
   end
 
-  def create_request_issues_for_vacature
-    vacated_issues.map(&:create_contesting_request_issue!)
+  def request_issues_for_vacatur
+    @request_issues_for_vacatur ||= RequestIssue.where(contested_decision_issue_id: vacated_decision_issue_ids)
+  end
+
+  def create_request_issues_for_vacatur
+    decision_issues_for_vacatur.map(&:create_contesting_request_issue!)
+  end
+
+  def vacated_decision_issues
+    @vacated_decision_issues ||= request_issues_for_vacatur.map { |ri| ri.decision_issues.first }
+  end
+
+  def create_vacated_decision_issues
+    request_issues_for_vacatur.map(&:create_vacated_decision_issue!)
   end
 
   private

app/models/request_issue.rb

@@ -478,6 +478,18 @@ def create_decision_issue_from_params(decision_issue_param)
     )
   end
 
+  def create_vacated_decision_issue!
+    decision_issues.find_or_create_by!(
+      decision_review: decision_review,
+      decision_review_type: decision_review_type,
+      disposition: "vacated",
+      description: "The decision: #{description} has been vacated.",
+      caseflow_decision_date: Time.zone.today,
+      benefit_type: benefit_type,
+      participant_id: decision_review.veteran.participant_id
+    )
+  end
+
   def requires_record_request_task?
     eligible? && !is_unidentified && !benefit_type_requires_payee_code?
   end

app/workflows/post_decision_motion_updater.rb

@@ -57,6 +57,7 @@ def create_motion
     end
 
     motion.save
+    motion
   end
 
   # We create an AbstractMotionToVacateTask as sibling to the JudgeAddressMotionToVacateTask
@@ -85,6 +86,8 @@ def handle_grant
 
     vacate_stream = appeal.create_stream(:vacate)
     create_new_stream_tasks(vacate_stream)
+    post_decision_motion.create_request_issues_for_vacatur
+    post_decision_motion.create_vacated_decision_issues
   end
 
   def create_abstract_task

spec/controllers/post_decision_motions_controller_spec.rb

@@ -5,6 +5,8 @@
   let(:judge) { create(:user) }
   let(:judge_team) { JudgeTeam.create_for_judge(judge) }
 
+  let(:post_decision_motion) { create(:post_decision_motion) }
+
   before do
     User.authenticate!(roles: ["System Admin"])
     User.stub = judge

spec/factories/post_decision_motions.rb

@@ -2,7 +2,24 @@
 
 FactoryBot.define do
   factory :post_decision_motion do
-    disposition { "MyString" }
-    task { nil }
+    task { create(:judge_address_motion_to_vacate_task) }
+    disposition { "granted" }
+    vacate_type { "straight_vacate" }
+
+    before(:create) do |post_decision_motion|
+      appeal = post_decision_motion.task.appeal
+      return unless appeal.reload.decision_issues.empty?
+
+      3.times do |idx|
+        create(
+          :decision_issue,
+          :rating,
+          decision_review: appeal,
+          disposition: "denied",
+          description: "Decision issue description #{idx}",
+          decision_text: "decision issue"
+        )
+      end
+    end
   end
 end

spec/feature/queue/motion_to_vacate_spec.rb

@@ -281,7 +281,7 @@
       motion = PostDecisionMotion.find_by(task: judge_address_motion_to_vacate_task)
       expect(motion).to_not be_nil
       expect(motion.disposition).to eq("partially_granted")
-      expect(motion.vacated_issues.length).to eq(issues_to_select.length)
+      expect(motion.decision_issues_for_vacatur.length).to eq(issues_to_select.length)
 
       visit_vacate_stream
     end

spec/models/post_decision_motion_spec.rb

@@ -9,12 +9,15 @@
   end
   let(:motions_atty) { create(:user, full_name: "Motions attorney") }
   let(:appeal) { create(:appeal) }
+  let(:vacate_stream) { appeal.create_stream(:vacate) }
   let(:orig_decision_issues) do
-    Array.new(3) do
+    Array.new(3) do |index|
       create(
         :decision_issue,
         decision_review: appeal,
-        disposition: "denied"
+        disposition: "denied",
+        description: "issue #{index}",
+        participant_id: appeal.veteran.participant_id
       )
     end
   end
@@ -41,15 +44,34 @@
     lit_support_team.add_user(motions_atty)
   end
 
-  context "handles creation of request issues" do
+  context "#create_request_issues_for_vacatur" do
     let(:disposition) { "granted" }
     let(:vacate_type) { "vacate_and_readjudication" }
+    subject { post_decision_motion.create_request_issues_for_vacatur }
 
     it "creates a request issue for every selected decision issue" do
-      expect(appeal.request_issues.length).to eq 0
-      post_decision_motion.create_request_issues_for_vacature
-      appeal.reload
-      expect(appeal.request_issues.length).to eq 3
+      expect(vacate_stream.request_issues.size).to eq 0
+      subject
+      vacate_stream.reload
+      expect(vacate_stream.request_issues.size).to eq 3
+    end
+  end
+
+  context "#create_vacated_decision_issues" do
+    let(:disposition) { "granted" }
+    let(:vacate_type) { "vacate_and_readjudication" }
+    subject { post_decision_motion.create_vacated_decision_issues }
+
+    before do
+      vacate_stream.reload
+    end
+
+    it "creates a vacated decision issue for every selected decision issue" do
+      expect(post_decision_motion.decision_issues_for_vacatur.size).to eq 3
+      post_decision_motion.create_request_issues_for_vacatur
+      subject
+      vacate_stream.reload
+      expect(vacate_stream.decision_issues.size).to eq 3
     end
   end
 end

spec/workflows/post_decision_motion_updater_spec.rb

@@ -12,7 +12,7 @@
   end
   let(:motions_atty) { create(:user, full_name: "Motions attorney") }
   let(:appeal) { create(:appeal) }
-  let(:orig_decision_issues) do
+  let!(:orig_decision_issues) do
     Array.new(3) do
       create(
         :decision_issue,
@@ -65,6 +65,8 @@
           expect(task.reload.status).to eq Constants.TASK_STATUSES.completed
           verify_vacate_stream
         end
+
+        it "should create decision issues on new vacate"
       end
 
       context "when vacate type is straight vacate" do
@@ -74,6 +76,7 @@
           subject.process
           expect(task.reload.status).to eq Constants.TASK_STATUSES.completed
           verify_vacate_stream
+          verify_decision_issues_created
         end
 
         it "saves all decision issue IDs for full grant" do
@@ -92,6 +95,8 @@
           subject.process
           expect(task.reload.status).to eq Constants.TASK_STATUSES.completed
           verify_vacate_stream
+          verify_vacate_stream
+          verify_decision_issues_created
         end
       end
 
@@ -217,9 +222,11 @@
     end
   end
 
-  def verify_vacate_stream
-    vacate_stream = Appeal.find_by(stream_docket_number: appeal.docket_number, stream_type: "vacate")
+  def vacate_stream
+    Appeal.find_by(stream_docket_number: appeal.docket_number, stream_type: "vacate")
+  end
 
+  def verify_vacate_stream
     expect(vacate_stream).to_not be_nil
     expect(vacate_stream.claimant.participant_id).to eq(appeal.claimant.participant_id)
 
@@ -235,4 +242,13 @@ def verify_vacate_stream
 
     expect(attorney_task).to_not be_nil
   end
+
+  def verify_decision_issues_created
+    motion = PostDecisionMotion.first
+    request_issues = vacate_stream.request_issues
+    expect(request_issues.size).to eq(motion.decision_issues_for_vacatur.size)
+
+    decision_issues = vacate_stream.decision_issues
+    expect(decision_issues.size).to eq(motion.decision_issues_for_vacatur.size)
+  end
 end