Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Vacated Decision Issues from Request Issues #13173

Merged
merged 41 commits into from
Feb 7, 2020
Merged

Create Vacated Decision Issues from Request Issues #13173

merged 41 commits into from
Feb 7, 2020

Commits on Dec 18, 2019

  1. added basic support for creating request issues from selected MTV dec… 

    …ision issues
    JC Quirin committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    38b1d58 View commit details
    Browse the repository at this point in the history

  2. only create request issues if disposition is grant type

    JC Quirin committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    8d5c8f3 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2019

  1. Merge branch 'master' into jc/12373-mtv-create-request-issues

    JC Quirin committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    83d41bc View commit details
    Browse the repository at this point in the history

  2. moved creation of request issues to PostDecisionMotion model; 

    adjusted tests accordingly;
    JC Quirin committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    1f4cea5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into jc/12373-mtv-create-request-issues

    JC Quirin committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    a9470c4 View commit details
    Browse the repository at this point in the history

  4. adjustments to post_decision_motion_updater_spec to allow tests re in… 

    …active atty to pass

(ensure variables are created in necessary order)
    JC Quirin committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    29af3f7 View commit details
    Browse the repository at this point in the history

  5. linting

    JC Quirin committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    63ba17f View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2019

  1. we now save all MTV issue IDs for "granted" disposition

    JC Quirin committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    c3a5296 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into jc/12373-mtv-create-request-issues

    JC Quirin committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    c4488d2 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2019

  1. we now add all decision issue IDs for full grant in PostDecisionMotio… 

    …nUpdater rather than on frontend;

additional fields saved in newly created request issues;
    JC Quirin committed Dec 24, 2019
    Configuration menu
    Copy the full SHA
    80cf6b8 View commit details
    Browse the repository at this point in the history

  2. added test for PostDecisionMotionUpdater adding all vacated_decision_… 

    …issue_ids for full grant
    JC Quirin committed Dec 24, 2019
    Configuration menu
    Copy the full SHA
    b55570f View commit details
    Browse the repository at this point in the history

  3. linting

    JC Quirin committed Dec 24, 2019
    Configuration menu
    Copy the full SHA
    84e4cac View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2020

  1. updated schema to indicate addtl usage of vacated_decision_issue_ids … 

    …field
    JC Quirin committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    18451dc View commit details
    Browse the repository at this point in the history

  2. better logic for populating vacated_decision_issue_ids field in PostD… 

    …ecisionMotionUpdater
    JC Quirin committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    84140b9 View commit details
    Browse the repository at this point in the history

  3. fixed wrong naming in disposition check in PostDecisionMotionUpdater

    JC Quirin committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    4707bfc View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2020

  1. Merge branch 'master' into jc/12373-mtv-create-request-issues

    JC Quirin committed Jan 4, 2020
    Configuration menu
    Copy the full SHA
    9d6fce1 View commit details
    Browse the repository at this point in the history

  2. removed superfluous commented line

    JC Quirin committed Jan 4, 2020
    Configuration menu
    Copy the full SHA
    504fc81 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2020

  1. moved logic for creating request issue from decision issue to Decisio… 

    …nIssue
    JC Quirin committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    c0b14b8 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2020

  1. began adding new_decision_issue_from! method to RequestIssue

    JC Quirin committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    ae016df View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2020

  1. Merge branch 'master' into jc/13069-mtv-create-decision-issues

    JC Quirin committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    99fcccb View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2020

  1. updated method name in RequestIssue to "create_vacated_decision_issue!"

    JC Quirin committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    dc869f3 View commit details
    Browse the repository at this point in the history

  2. added code & tests for generating vacated decision issues from PostDe… 

    …cisionMotion;

moved `create_vacated_decision_issue` in RequestIssue to make method accessible;
    JC Quirin committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    9c4536f View commit details
    Browse the repository at this point in the history

  3. adjustments per codeclimate

    JC Quirin committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    425cdf9 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2020

  1. Merge branch 'master' into jc/13069-mtv-create-decision-issues

    JC Quirin committed Jan 18, 2020
    Configuration menu
    Copy the full SHA
    b98d0c5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into jc/13069-mtv-create-decision-issues

    JC Quirin committed Jan 18, 2020
    Configuration menu
    Copy the full SHA
    fb34f9d View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2020

  1. updated various items in DecisionIssue, RequestIssue, & PostDecisionM… 

    …otion:

renamed methods, and separated methods for creation of issues from those that return said issues;
renamed tests;
    JC Quirin committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    f684246 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into jc/13069-mtv-create-decision-issues

    JC Quirin committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    a26e0c9 View commit details
    Browse the repository at this point in the history

  3. fixed error in MTV test

    JC Quirin committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    ea02577 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into jc/13069-mtv-create-decision-issues

    JC Quirin committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    74679be View commit details
    Browse the repository at this point in the history

  5. began adding PostDecisionMotionController.create_issues endpoint & tests

    JC Quirin committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    7d01a8b View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2020

  1. added "create_issues" endpoint on PostDecisionMotionsController: 

    this creates request issues & decision issues based off the specified PostDecisionMotion
    JC Quirin committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    1e2baaa View commit details
    Browse the repository at this point in the history

  2. linting

    JC Quirin committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    8e78862 View commit details
    Browse the repository at this point in the history

  3. removed mistaken commit of modified capybara.rb

    @jcq
    jcq authored Jan 22, 2020
    Configuration menu
    Copy the full SHA
    cb160e0 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2020

  1. DecisionIssue.create_contesting_request_issue now adds new request is… 

    …sues to new "vacate" appeal stream
    JC Quirin committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    be25dff View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2020

  1. Merge branch 'master' into jc/13069-mtv-create-decision-issues

    JC Quirin committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    ae0395c View commit details
    Browse the repository at this point in the history

  2. moved calls to create new request & decision issues to PostDecisionMo… 

    …tionUpdater;

new issues are created on the vacate stream;
    JC Quirin committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    b9ee9a6 View commit details
    Browse the repository at this point in the history

  3. removed create_issues & related from PostDecisionMotionsController

    JC Quirin committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    c376303 View commit details
    Browse the repository at this point in the history

  4. updated tests in post_decision_motion_spec

    JC Quirin committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    ba135f4 View commit details
    Browse the repository at this point in the history

  5. removed tests for PostDecisionMotionsController.create_tasks

    JC Quirin committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    5d84d90 View commit details
    Browse the repository at this point in the history

  6. removed unsed route for create_issues off of PostDecisionMotionsContr… 

    …oller
    JC Quirin committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    583d3de View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into jc/13069-mtv-create-decision-issues

    va-bot authored Feb 7, 2020
    Configuration menu
    Copy the full SHA
    0d24049 View commit details
    Browse the repository at this point in the history