Do not show inactive users as options for task assignee #13111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmo
commented
Jan 9, 2020
client/COPY.json
Outdated
| @@ -230,7 +230,7 @@ | |||
| "ASSIGN_WIDGET_NO_TASK_DETAIL": "Please select a task.", | |||
| "ASSIGN_WIDGET_SUCCESS": "%(verb)s %(numCases)s %(casePlural)s", | |||
| "ASSIGN_WIDGET_ASSIGNMENT_ERROR_TITLE": "Error assigning tasks", | |||
| "ASSIGN_WIDGET_ASSIGNMENT_ERROR_DETAIL": "One or more tasks couldn't be assigned. Reassign tasks to a judge on the case deatils screen", | |||
| "ASSIGN_WIDGET_ASSIGNMENT_ERROR_DETAIL": "One or more tasks couldn't be assigned. Reassign tasks to a judge on the case details screen", | |||
kevmo
changed the title
|
Code Climate has analyzed commit cfa5a4d and detected 0 issues on this pull request. View more on Code Climate. |
…fairs/caseflow into 12949/inactive-users-task-assignee
ajspotts
approved these changes
Jan 13, 2020
kevmo
added
the
Ready-to-Merge
hschallhorn
reviewed
Jan 13, 2020
hschallhorn
reviewed
Jan 13, 2020
|
|
||
| def potential_task_assignees(task) | ||
| if task.assigned_to.is_a?(Organization) | ||
| task.assigned_to.users.reject(&:inactive?) |
There was a problem hiding this comment.
Enums come with scopes for free as well. This can be simplified to task.assigned_to.users.active
There was a problem hiding this comment.
Tried to go that route, but it doesn't work because task.assigned_to.users is a Ruby array, not an Active Record object.
hschallhorn
reviewed
Jan 13, 2020
| if task.assigned_to.is_a?(Organization) | ||
| task.assigned_to.users.reject(&:inactive?) | ||
| elsif task.parent&.assigned_to.is_a?(Organization) | ||
| task.parent.assigned_to.users.reject do |check_user| |
There was a problem hiding this comment.
Same thing here, we can keep the original logic and just add .active after users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12949
Description
In "Assign to Person" task assignment modals, we were offering inactive users
Acceptance Criteria
Testing Plan
User.find_by_css_id("ORG_QUEUE_USER_5").inactive!User Facing Changes
BEFORE:
AFTER:
