-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not show inactive users as options for task assignee #12949
Comments
Estimated at a 3. Might be a 5 as it will take extensive rspec testing & manual testing, and we're unsure of all the places we have to implement this. Concerned there are places that if we add the active scope, we'll affect other places we actually wanted all the users. If we get into this and we find out there are huge knock on effects on many unrelated places, maybe we need to refactor the behavior into better isolated code. Might end up needed a new route (one active, one all), and will have to decide which to leave the current as and which to implement the new route (lift to update vs lift to maintain going forward). A 2 is optimistic, but possible. It will still take a lot of testing even if the implementation is straightfoward. Notes Limit the round robin assignee pool to the active scope for users. Might be able to make this toggle in one place at the user controller, but maybe there are other places. There is some digging and research in this task to confirm we have them all. Some new tests will be needed. |
Sticky spots so far:
|
Resolves #12949 ### Description In "Assign to Person" task assignment modals, we were offering inactive users ### Acceptance Criteria - [ ] Test suite passes. ### Testing Plan 1. Log in as translation team member #1, e.g. ORG_QUEUE_USER_1 2. Navigate to http://localhost:3000/organizations/translation, open a case (e.g. http://localhost:3000/queue/appeals/2e7d0f5b-f9eb-4767-9b41-40426d9b0562) 3. In task actions, go to "Assign to Person". You should see Translation team member #5. 4. Now make Translation team member #5 as inactive in the rails console: `User.find_by_css_id("ORG_QUEUE_USER_5").inactive!` 5. Repeat steps 1 through 3. You should no longer see Team Member 5. ### User Facing Changes BEFORE: <img width="1029" alt="Screen Shot 2020-01-13 at 9 54 00 AM" src="https://user-images.githubusercontent.com/1034221/72265627-ce6b9d80-35ea-11ea-8a78-5fa5fd7e2158.png"> AFTER: <img width="1070" alt="Screen Shot 2020-01-13 at 9 58 46 AM" src="https://user-images.githubusercontent.com/1034221/72265913-4f2a9980-35eb-11ea-846f-a4242d69edf1.png">
When a user sees a selection of other users to assign a task to, they should not see inactive users as an option.
AC
Notes
Here's some possible context
The text was updated successfully, but these errors were encountered: