screenreader now capable of reading checkbox group #12559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit ada6341 and detected 0 issues on this pull request. View more on Code Climate. |
kevmo
reviewed
Nov 1, 2019
| }) | ||
| } | ||
| </div> | ||
| <fieldset style={{ width: '100%' }}> |
There was a problem hiding this comment.
Styling should probably be put into a variable elsewhere, then injected via that variable.
kevmo
reviewed
Nov 1, 2019
| </p> | ||
| <TabWindow tabs={tabs} onChange={this.onTabSelected} /> | ||
| </div> | ||
| )} |
There was a problem hiding this comment.
Is everything above this line just formatting? Was having a hard time seeing any other differences.
There was a problem hiding this comment.
Yes, had to re-formate after initial commit to undo changes from Prettier extension hence all the changes. Sorry for the confusion!
kevmo
reviewed
Nov 1, 2019
ajspotts
added
the
Ready-to-Merge
|
Looks awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #{12123}
Description
Enables users who utilize assistive technology to identify the name of the group ("Special Issues") that the checkboxes are located in by adding elements
<fieldset>&<legend>identified by W3C standards as readable by a screenreader