Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch: Special Issues checkboxes are not grouped together (End: 7/10) #12123

Closed
alisan16 opened this issue Sep 17, 2019 · 10 comments
Closed
Assignees
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-dispatch Team: Foxtrot 🦊 Type: Accessibility Related to Accessibility support (Section 508)

Comments

@alisan16
Copy link
Contributor

Checkboxes need to be grouped and labeled for 'Special Issues' on Establish Next Claim page

On the Establish Next claim page the label: Special Issue(s) is not read with the check box selections for assistive technology users. (New: 08/27/2019) The boxes need to be grouped and the label read “select special issue(s)” with all the checkboxes

Suggested fix: https://www.w3.org/WAI/tutorials/forms/grouping/

@ajspotts
Copy link
Contributor

Alisa can you tell me where this view (the url) is located?

@alisan16
Copy link
Contributor Author

Sure - these issues are all related to Caseflow Demo: www.caseflowdemo.com

This specific issue is on http://www.caseflowdemo.com/dispatch/establish-claim/1#/decision
You can test it out with test user: BVAAABSHIRE (VACO) on Caseflow Demo and then navigating to Dispatch > Work History > Establish Next Claim then scroll down the page until you see the checkboxes.

Screen Shot 2019-10-18 at 3 23 15 PM

Screen Shot 2019-10-18 at 3 24 07 PM

Screen Shot 2019-10-18 at 3 24 30 PM

@ajspotts
Copy link
Contributor

@alisan16 Does a solution to this problem require testing with JAWS or is VoiceOver testing considered to be sufficient? Asking after I peaked in on issue 12096

@alisan16
Copy link
Contributor Author

@ajspotts Yes, please take a look at the linked epic for instructions for how to reproduce and test the issues. You can use the standard screenreader installed on your computer, which on Mac is Voiceover and on Windows is Narrator, I believe. If you have access to a GFE or CAG Windows computer, the JAWS program should be installed and you can use that as well.

#12095

@ajspotts
Copy link
Contributor

ajspotts commented Nov 5, 2019

Resolved by this ticket

@ajspotts ajspotts closed this as completed Nov 5, 2019
@alisan16 alisan16 added the Type: Accessibility Related to Accessibility support (Section 508) label Mar 4, 2020
@araposo-tistatech
Copy link

Reopening, per the latest accessibility audit this is not resolved:

  • The following occurs with the Dispatch application:
    • On the Establish Next claim page the label: Special Issue(s) is not read with the check box selections for assistive technology users. (New: 08/27/2019) The boxes need to be grouped and the label read “select special issue(s)” with all the checkboxes (Not Resolved 3/26/2020)

@msj0nes msj0nes added Team: Foxtrot 🦊 Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. labels May 22, 2020
@msj0nes msj0nes changed the title Dispatch: Special Issues checkboxes are not grouped together Dispatch: Special Issues checkboxes are not grouped together (End: 7/10) May 26, 2020
@leikkisa leikkisa self-assigned this Jun 10, 2020
@leikkisa
Copy link
Contributor

leikkisa commented Jun 15, 2020

@araposo-tistatech
I tested the current page, as well as the page in the guidelines on https://www.w3.org/WAI/tutorials/forms/grouping/

The Mac screen reader only reads the checkbox group once the first time you interact with it. Subsequently, it does not include the group information when reading each checkbox. This behavior is happening on the Dispatch page, as well as the W3 page.

The code for the page does have the recommended HTML code to group the checkboxes, using a fieldset with a legend (here's a snippet just from the top, and the checkboxes are contained within the fieldset). This was added in Alec's PR here.

          <fieldset className="fieldset">
            <legend>
              <label>
                <b>Select Special Issues</b>
              </label>
            </legend>

@leikkisa
Copy link
Contributor

leikkisa commented Jun 15, 2020

Here's a screenshot of the first time the voiceover reader interacts with a checkbox within the group. Same happens if it's another checkbox in the right column of checkboxes, but only if it's the first one we interact with. Since this is the same behavior as the example of the standard, not sure what else we can do.

Screen Shot 2020-06-15 at 3.42.18 PM.png

@araposo-tistatech
Copy link

@chandracarney please see the above and advise how we should move forward.

@leikkisa
Copy link
Contributor

leikkisa commented Jun 18, 2020

Checked this out with JAWS today too, and am seeing similar behavior. The first checkbox item gets the group title announced, but not every checkbox. Same for the W3 page. If navigating away from the checkbox group, and then back again, it reads the group name again for the first checkbox item.

Here's some notes from the JAWS voice text:
Starting navigation from the element above the checkboxes:
Decision type �read only edit�
Full Grant
Use your reading keys to read the text.

When navigating to the checkbox group - reads group for first one only
Select Special Issues �group�
contaminatedWaterAtCampLejeune �check box� �not checked�
To check press Spacebar.
dicDeathOrAccruedBenefitsUnitedStates �check box� �not checked�
To check press Spacebar.
educationGiBillDependentsEducationalAssistanceScholarshipTransferOfEntitlement �check box� �not checked�
To check press Spacebar.
dicDeathOrAccruedBenefitsUnitedStates �check box� �not checked�
To check press Spacebar.
contaminatedWaterAtCampLejeune �check box� �not checked�
To check press Spacebar.

Navigating back to the above element
Decision type �read only edit�
Full Grant
Use your reading keys to read the text.

Reads the group again when we go back
Select Special Issues �group�
contaminatedWaterAtCampLejeune �check box� �not checked�
To check press Spacebar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-dispatch Team: Foxtrot 🦊 Type: Accessibility Related to Accessibility support (Section 508)
Projects
None yet
Development

No branches or pull requests

5 participants