Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only reopen judge assign tasks if attorney tasks are cancelled #12491

Merged
merged 9 commits into from
Oct 28, 2019

Conversation

hschallhorn
Copy link
Contributor

@hschallhorn hschallhorn commented Oct 28, 2019

Resolves bug where all attorney tasks would cancel their parent and open another JudgeAssignTask when cancelled

Acceptance Criteria

  • ONLY AttorneyTasks cancel their parent and open another JudgeAssignTask when cancelled

Testing Plan

AttorneyQualityReviewTask

  1. Sign in as QR_USER and return any ama task to a judge
  2. Sign in as that judge and send that task back to the attorney
  3. Cancel the task that was just created
  4. Ensure the QR task is still in the judge's queue and an assign task has not been created

AttorneyDispatchReturnTask

  1. Sign in as BVAGWHITE and return any ama task to a judge
  2. Sign in as that judge and send that task back to the attorney
  3. Cancel the task that was just created
  4. Ensure the dispatch task is still in the judge's queue and an assign task has not been created

AttorneyRewriteTask

  1. SIgn in as BVAAASHIRE and return any ama task to an attorney
  2. Cancel the task that was just created
  3. Ensure the decision review task is still in the judge's queue and an assign task has not been created

@hschallhorn hschallhorn self-assigned this Oct 28, 2019
@codeclimate
Copy link

codeclimate bot commented Oct 28, 2019

Code Climate has analyzed commit 13bdbac and detected 0 issues on this pull request.

View more on Code Climate.

@va-bot
Copy link
Collaborator

va-bot commented Oct 28, 2019

1 Warning
⚠️ This PR adds one or more new specs. If the specs use the DB, see if you can rewrite them so they don’t use the DB, such as by using build_stubbed. If they must use the DB, please remember to add the appropriate require statements and either the :postgres or :all_dbs tags, as documented in our Wiki: https://github.com/department-of-veterans-affairs/caseflow/wiki/Testing-Best-Practices#tests-that-write-to-the-db

Generated by 🚫 Danger

Copy link
Contributor

@lomky lomky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 :shipit:

@hschallhorn hschallhorn added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Oct 28, 2019
@hschallhorn hschallhorn merged commit bab4a7f into master Oct 28, 2019
@hschallhorn hschallhorn deleted the hschallhorn/fix-cancel-attorney-task branch October 28, 2019 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants