Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create AttorneyDecisionDraftingTask #14133

Closed
3 tasks
hschallhorn opened this issue Apr 29, 2020 · 1 comment
Closed
3 tasks

Create AttorneyDecisionDraftingTask #14133

hschallhorn opened this issue Apr 29, 2020 · 1 comment
Labels
Feature: generic-queue Priority: Low Reported issue, not a blocker. "Last in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Tech-Improvement

Comments

@hschallhorn
Copy link
Contributor

hschallhorn commented Apr 29, 2020

Similar to how we have an abstracted JudgeTask for all tasks that can be assigned to a judge, we should have an abstracted AttorneyTask for all of our attorney tasks and create a task specific to drafting a decision.

git grep ' < JudgeTask'
app/models/tasks/judge_address_motion_to_vacate_task.rb:class JudgeAddressMotionToVacateTask < JudgeTask
app/models/tasks/judge_assign_task.rb:class JudgeAssignTask < JudgeTask
app/models/tasks/judge_decision_review_task.rb:class JudgeDecisionReviewTask < JudgeTask
app/models/tasks/judge_dispatch_return_task.rb:class JudgeDispatchReturnTask < JudgeTask
app/models/tasks/judge_quality_review_task.rb:class JudgeQualityReviewTask < JudgeTask
git grep ' < AttorneyTask'
app/models/tasks/attorney_dispatch_return_task.rb:class AttorneyDispatchReturnTask < AttorneyTask
app/models/tasks/attorney_quality_review_task.rb:class AttorneyQualityReviewTask < AttorneyTask
app/models/tasks/attorney_rewrite_task.rb:class AttorneyRewriteTask < AttorneyTask

AC

  • Create AttorneyDecisionDraftingTask
  • Update instances of AttorneyTask to AttorneyDecisionDraftingTask in our code (See notes)
  • Tasks of type "AttorneyTask" are updated to type "AttorneyDecisionDraftingTask" in prod

Notes

Be wary of the difference between AttorneyTask.where and Task.where(type: AttroneyTask.name. The first will return all attorney subclasses as well, while the second will only return what we consider the initial attorney drafting task. #12491 is a good example of how we fell prey to this in the past.

We should be sure to update our factories, move attorney tasks out of TASK_CLASSES_LOOKUP and into additional_task_classes

@hschallhorn hschallhorn added Feature: generic-queue Priority: Low Reported issue, not a blocker. "Last in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Tech-Improvement labels Apr 29, 2020
@ajspotts
Copy link
Contributor

what is this chart?

1 | 
2 | ||||||
3 | ||||||
5 | 
8 | 

Why 3?

  • knock on effects from rename

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: generic-queue Priority: Low Reported issue, not a blocker. "Last in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Tech-Improvement
Projects
None yet
Development

No branches or pull requests

3 participants