Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show converted Travel Board hearings in RO queue immediately #15426

Closed
1 task
lund5000 opened this issue Oct 14, 2020 · 0 comments · Fixed by #15487
Closed
1 task

Show converted Travel Board hearings in RO queue immediately #15426

lund5000 opened this issue Oct 14, 2020 · 0 comments · Fixed by #15487
Assignees
@ferristseng
Labels
Product: caseflow-hearings Team: Tango 💃
Milestone
PI5-S6: Dizzy Gil...

Comments

@lund5000
Copy link
Contributor

lund5000 commented Oct 14, 2020 •
edited
Loading

User story

As a hearing coordinator, I want hearings that I convert from Travel Board to virtual to show up in the RO queues (more or less) immediately so I can more quickly shift to building dockets.

Background

Currently we rely on the background jobs to geo-match and cache these appeals, but depending on the number of appeals with open tasks it can take several hours to successfully show up in the RO queue. Coordinators are looking to convert a number of Travel Board hearings in a row, head over the RO queue, filter their queue to show only virtual/former Travel Board, and start building docket days.

Acceptance criteria

  • When a user completes the "Convert hearing to virtual" action on a Travel Board hearing, it immediately shows up in the geo-matched RO queue

Technical notes

We can geo-match and cache on the fly as part of the conversion process. This will affect performance because we're making a call to VA.gov and maybe a request to VACOLS.

We will have to do these asynchronously. We may not have to do the geomatching because it should be geomatched already.

We don't have a way to cache individual appeals with the current job. It would have to be modified to accept arguments to run against a single appeal.

Are there race conditions that could be created by starting the job for an individual appeal when the existing job is already running?
@lund5000 lund5000 added this to the PI5-S6: XXX Sprint milestone Oct 15, 2020
@lund5000 lund5000 mentioned this issue Oct 16, 2020
Closed
@ferristseng ferristseng self-assigned this Oct 21, 2020
@ferristseng ferristseng mentioned this issue Oct 23, 2020
Merged
1 task
va-bot pushed a commit that referenced this issue Oct 28, 2020
@ferristseng
Create job to cache travel board appeals immediately (#15487)
3fb712b 
Resolves #15426 

### Description

- Moved `FetchHearingLocationsForVeteransJob` logic to `GeomatchService`
- Moved `UpdateCachedAppealsAttributesJob` logic to `CachedAppealService`
  - Refactored some existing logic to get rid of some CodeClimate warnings. The remaining ones I think we can ignore
- Add `Hearings::GeomatchAndCacheAppealJob`, and start it when completing `ChangeHearingRequestTypeTask`
- Update and add tests
- Resolves merge conflicts from #15482 and #15478

### Acceptance Criteria
- [x] When a user completes the "Convert hearing to virtual" action on a Travel Board hearing, it immediately shows up in the geo-matched RO queue

### Testing Plan
1. Login as BVASYELLOW
2. Go to http://localhost:3000/queue/appeals/1986897
3. Work the change appeal type task
4. Go to the schedule veteran page for St. Petersburg, and ensure the case shows up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferristseng ferristseng

Labels
Product: caseflow-hearings Team: Tango 💃
Projects
None yet
Milestone
PI5-S6: Dizzy Gillespie Sprint
Development

Successfully merging a pull request may close this issue.

Create job to cache travel board appeals immediately department-of-veterans-affairs/caseflow
2 participants
@lund5000 @ferristseng