Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dogfooding Bug] No email validation on the hearing details page when modifying a virtual hearing's email #14990

Closed
1 task
ferristseng opened this issue Aug 14, 2020 · 0 comments · Fixed by #15044
Closed
1 task

[Dogfooding Bug] No email validation on the hearing details page when modifying a virtual hearing's email #14990

ferristseng opened this issue Aug 14, 2020 · 0 comments · Fixed by #15044
Assignees
@ferristseng
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-hearings Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Tango 💃 Type: Bug
Milestone
PI5-S2: Edith S. ...

Comments

@ferristseng
Copy link
Contributor

Description

Screen Shot 2020-08-14 at 3.46.29 PM.png

There is no validation when the user enters an invalid email into the "Veteran Email" or "POA/Representative Email" fields. The page still displays a notification saying the virtual hearing was updated after confirming the "Update Email" modal. The user needs to be notified when they enter an incorrect email address.

Acceptance criteria

  • Ensure validations display when modifying any email address on the hearing details page for a virtual hearing

Background/context/resources

Technical notes
@ferristseng ferristseng added Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-hearings Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Tango 💃 Type: Bug labels Aug 14, 2020
@ferristseng ferristseng self-assigned this Aug 19, 2020
@ferristseng ferristseng mentioned this issue Aug 21, 2020
Merged
1 task
@lund5000 lund5000 mentioned this issue Aug 25, 2020
Closed
va-bot pushed a commit that referenced this issue Aug 25, 2020
@ferristseng
Fix bug on hearing details page where email error messages weren't be…
9afb417 
…ing displayed (#15044)

Resolves #14990 

### Description

 - Update server to throw if there are validation errors (`update => update!`)
 - Update server to handle setting the representative email to null
   - Updated server to not send down virtual hearing notification alerts if only the representative email was updated
 - Small fixes to remove PropType warnings
 - Add tests for email validations on the hearing details page

### Acceptance Criteria
- [x] Ensure validations display when modifying any email address on the hearing details page for a virtual hearing

### Testing Plan
1. Login as a Hearing Coordinator
2. Go to the hearing details page for a virtual hearing
3. Try changing representative email to `123456`
4. Try deleting the representative email
5. Try changing veteran email *and* deleting the representative email
6. Try changing the representative timezone *and then* deleting the representative email (the timezone should revert)
7. Try making both the veteran email and representative email invalid

### User Facing Changes

<img width="839" alt="Screen Shot 2020-08-25 at 10 44 44 AM" src="https://user-images.githubusercontent.com/1298274/91189069-ff06d000-e6bf-11ea-8450-e13f8c7e33bc.png">
@lund5000 lund5000 added this to the PI5-S2: Edith S. Sampson milestone Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferristseng ferristseng

Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-hearings Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Tango 💃 Type: Bug
Projects
None yet
Milestone
PI5-S2: Edith S. Sampson
2 participants
@lund5000 @ferristseng