Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect non-modal schedule veterans view with backend and actions menu #14895

Closed
6 tasks
ferristseng opened this issue Aug 5, 2020 · 0 comments · Fixed by #15212
Closed
6 tasks

Connect non-modal schedule veterans view with backend and actions menu #14895

ferristseng opened this issue Aug 5, 2020 · 0 comments · Fixed by #15212
Assignees
@sahalliburton
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-hearings Team: Tango 💃 Type: Enhancement Enhancement to an existing feature
Milestone
PI5-S3: Chadwick ...

Comments

@ferristseng
Copy link
Contributor

ferristseng commented Aug 5, 2020 •
edited
Loading

Description

Connect the non-modal schedule veterans view with the task actions menu on the case details page and connect the form with the new/existing backend action.

Acceptance criteria

  • Ensure the non-modal schedule veterans view opens when working the schedule veteran task
  • Ensure that working through the workflow without changing the hearing type works as expected
  • Ensure that working through the workflow and changing the hearing type to virtual triggers an email to be sent
  • Ensure that working through the workflow successfully redirects you to the case details page
  • Ensure that validation errors are displayed on the schedule veterans view
  • Update test expectations (there are alot!)

Background/context/resources

Connected to #12941

Designs: https://www.figma.com/proto/V87TZArfdurCGJiEjQ73ES/Virtual-Hearings?node-id=6022%3A21726&viewport=-269%2C32%2C0.06443598121404648&scaling=min-zoom

Technical notes

Open Questions

  • Should this be behind a feature flag?
    • Nichole: From design perspective, users are aware of the new workflow
    • Tomas: We do for E2E testing
  • Should we create a follow up ticket to remove the old modal?
    • Yes
  • Do we need to reenable validation to ensure hearing coordinators don't schedule video hearings to days without rooms?
    • Don't let it block since ROs are still closed
@ferristseng ferristseng added Team: Tango 💃 Type: Enhancement Enhancement to an existing feature Product: caseflow-hearings Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. labels Aug 5, 2020
@ferristseng ferristseng mentioned this issue Aug 6, 2020
Closed
2 tasks
@lund5000 lund5000 mentioned this issue Aug 25, 2020
Closed
@sahalliburton sahalliburton mentioned this issue Sep 10, 2020
Merged
6 tasks
@sahalliburton sahalliburton self-assigned this Sep 10, 2020
va-bot pushed a commit that referenced this issue Sep 16, 2020
@sahalliburton
Connects the backend and frontend for the schedule veteran directly w…
5222cfd 
…orkflow (#15212)

Resolves #14895

Stack
- [Part 2](#15214)
- [Part 3](#15215)

### Description
Updates frontend and backend code to connect the functionality and complete the workflow for scheduling veterans directly to either Central Office, Video, or Virtual hearings.

### Acceptance Criteria
- [ ] Code compiles correctly
- [ ] Behavior is unchanged when the feature flag is disabled

### Testing Plan

**With Feature Flag**

*Central Hearing*
NOTE: You need to do some setup work for the Central flow, first get the `uuid` of an Appeal without a hearing scheduled and open a rails console. Run the following commands to make the central office hearing available to schedule: 

```
appeal = Appeal.find_by(uuid: "")
appeal.update!(closest_regional_office: "C")
CachedAppeal.create!(appeal_id: appeal.id, appeal_type: appeal.class.name, closest_regional_office_key: "C")
```

1. Shadow user `BVASYELLOW` and navigate to the hearings schedule
1. Click the `Schedule Veterans` button change the dropdown to `Central`
1. Change to the `AMA Veterans Waiting` tab and choose the appeal you just updated
1. Select the Schedule Veteran option from the Actions dropdown
1. Ensure the full page schedule veteran component is loaded
1. Fill in the hearing details and click `Schedule`
1. Ensure you receive a success message with a link back to schedule veterans

*Video Hearing*

1. Shadow user `BVASYELLOW` and navigate to the hearings schedule
1. Click the `Schedule Veterans` button change the dropdown to `St. Petersburg, FL`
1. Change to the `AMA Veterans Waiting` tab and choose the appeal you just updated
1. Select the Schedule Veteran option from the Actions dropdown
1. Ensure the full page schedule veteran component is loaded
1. Fill in the hearing details and click `Schedule`
1. Ensure you receive a success message with a link back to schedule veterans

*Virtual Hearing*

1. Shadow user `BVASYELLOW` and navigate to the hearings schedule
1. Click the `Schedule Veterans` button change the dropdown to `St. Petersburg, FL`
1. Change to the `AMA Veterans Waiting` tab and choose the appeal you just updated
1. Select the Schedule Veteran option from the Actions dropdown
1. Ensure the full page schedule veteran component is loaded
1. Change the hearing type to `Virtual`
1. Fill in the hearing details and click `Schedule`
1. Ensure you receive a success message with a link back to schedule veterans

**Without Feature Flag**

*Central Hearing*
NOTE: You need to do some setup work for the Central flow, first get the `uuid` of an Appeal without a hearing scheduled and open a rails console. Run the following commands to make the central office hearing available to schedule: 

```
appeal = Appeal.find_by(uuid: "")
appeal.update!(closest_regional_office: "C")
CachedAppeal.create!(appeal_id: appeal.id, appeal_type: appeal.class.name, closest_regional_office_key: "C")
```

1. Shadow user `BVASYELLOW` and navigate to the hearings schedule
1. Click the `Schedule Veterans` button change the dropdown to `Central`
1. Change to the `AMA Veterans Waiting` tab and choose the appeal you just updated
1. Select the Schedule Veteran option from the Actions dropdown
1. Ensure the full page schedule veteran component is loaded
1. Fill in the hearing details and click `Schedule`
1. Ensure you receive a success message with a link back to schedule veterans

*Video Hearing*

1. Shadow user `BVASYELLOW` and navigate to the hearings schedule
1. Click the `Schedule Veterans` button change the dropdown to `St. Petersburg, FL`
1. Change to the `AMA Veterans Waiting` tab and choose the appeal you just updated
1. Select the Schedule Veteran option from the Actions dropdown
1. Ensure the full page schedule veteran component is loaded
1. Fill in the hearing details and click `Schedule`
1. Ensure you receive a success message with a link back to schedule veterans

### User Facing Changes
 - [ ] Screenshots of UI changes added to PR & Original Issue

 BEFORE|AFTER
 ---|---
![Before-ConvertToCentral](https://user-images.githubusercontent.com/61989526/92796584-2c14dd00-f366-11ea-967c-f7f404c3e443.png)|![After-ConvertToCentral](https://user-images.githubusercontent.com/61989526/92796567-27e8bf80-f366-11ea-821c-feb075d024f0.png)
![Before-PostponeRescheduleImmediately](https://user-images.githubusercontent.com/61989526/92796576-2a4b1980-f366-11ea-8b05-4a3ffc2e0d52.png)|![After-PostponeRescheduleImmediately](https://user-images.githubusercontent.com/61989526/92796597-2cad7380-f366-11ea-8853-02983d1bdfe9.png)
![Before-ConvertToVideo](https://user-images.githubusercontent.com/61989526/92796583-2b7c4680-f366-11ea-9813-bf75c698199c.png)|![After-ConvertToVideo](https://user-images.githubusercontent.com/61989526/92796601-2d460a00-f366-11ea-99eb-3a72fc7b790b.png)
| |![After-ConvertToVirtual](https://user-images.githubusercontent.com/61989526/92796599-2d460a00-f366-11ea-960b-ca46f85f6db8.png)
| |![After-SchedulingInProgress](https://user-images.githubusercontent.com/61989526/92796590-2c14dd00-f366-11ea-978d-cb105c2c3bb0.png)
| |![After-SchedulingComplete](https://user-images.githubusercontent.com/61989526/92796594-2cad7380-f366-11ea-839b-030b5e9f94ff.png)



### Storybook Story
*For Frontend (Presentationa) Components*
* [x] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`)
* [x] Give it a title that reflects the component's location within the overall Caseflow hierarchy
* [x] Write a separate story (within the same file) for each discrete variation of the component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sahalliburton sahalliburton

Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-hearings Team: Tango 💃 Type: Enhancement Enhancement to an existing feature
Projects
None yet
Milestone
PI5-S3: Chadwick Boseman Sprint
4 participants
@lund5000 @ferristseng @tomas-nava @sahalliburton