Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to Virtual Conversion page bug fixes #14786

Closed
6 tasks done
chandracarney opened this issue Jul 28, 2020 · 0 comments · Fixed by #14837
Closed
6 tasks done

Convert to Virtual Conversion page bug fixes #14786

chandracarney opened this issue Jul 28, 2020 · 0 comments · Fixed by #14837
Assignees
@sahalliburton
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-hearings Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Tango 💃
Milestone
PI4-S7: Voting Ri...

Comments

@chandracarney
Copy link

chandracarney commented Jul 28, 2020 •
edited by tomas-nava
Loading

Description

On the Convert to Virtual flow :
Convert to virtual hearing button is stuck in loading state after changing email addresses (or on displaying an error after entering invalid email?)

In the POA section , if no POA:
If there is no POA, page should display The veteran does not have a representative recorded in VBMS where name and mailing address would live for both central -> virtual and virtual -> central flow https://www.figma.com/proto/V87TZArfdurCGJiEjQ73ES/Virtual-Hearings?node-id=5649%3A21459&scaling=min-zoom

In the POA section, if POA does not have address
For hearings with POA who does not have an address it should display the name of POA or Organization.

Validation errors for email fields should be inline with the fields

Review use of "appellant" vs "veteran" for error messages

Focus the top of the form page on initial load of the conversion page from the details page

For Convert to Central flow, if there was never a POA email entered, it should display None

Acceptance criteria

  • Display name of poa/organization if there's no poa address
  • Display message if there is no POA/representative
  • Inline error validation for email fields
  • Review usage of "Veteran" vs "Appellant" in error messaging
  • "Convert to virtual hearing" button should resolve loading state
  • Focus conversion page on top when it's loaded from hearing details

Background/context/resources

https://docs.google.com/document/d/12oJca2FKYr8ouWspef_1ReIc5g3pD_mDoEC7JLPgdsQ/edit

Technical notes
@chandracarney chandracarney added Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-hearings Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Tango 💃 labels Jul 28, 2020
@chandracarney chandracarney added this to the PI4-S7: XXX Sprint milestone Jul 28, 2020
@chandracarney chandracarney mentioned this issue Jul 28, 2020
Closed
@rubaiyat22 rubaiyat22 changed the title Convert to Virtual page bug fixes Convert to Virtual Conversion page bug fixes Jul 29, 2020
@sahalliburton sahalliburton self-assigned this Jul 29, 2020
@sahalliburton sahalliburton mentioned this issue Jul 30, 2020
Merged
1 task
va-bot pushed a commit that referenced this issue Jul 31, 2020
@sahalliburton
Resolve issues with converting central office hearings between virtua…
bd6666c 
…l type (#14837)

Resolves #14786 

### Description
Resolves bugs with converting hearing type between central and virtual, see the ticket for details on which bugs are resolved by this PR.

### Acceptance Criteria
- [ ] Code compiles correctly

### Testing Plan
1. Shadow user `BVASYELLOW`
1. Navigate to the hearing schedule and select a Central hearing: http://localhost:3000/hearings/schedule
1. Click the 'Edit Hearing Details' link
1. Change the type to Virtual
1. Go through the list of items in the ticket and ensure all of the issues are resolved
@tomas-nava tomas-nava mentioned this issue Aug 19, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sahalliburton sahalliburton

Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-hearings Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Tango 💃
Projects
None yet
Milestone
PI4-S7: Voting Rights Sprint
2 participants
@chandracarney @sahalliburton