Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make /queue/<css_id>/assign the default url to reach a judge's assign page #13913

Closed
3 tasks
hschallhorn opened this issue Apr 7, 2020 · 2 comments · Fixed by #14073
Closed
3 tasks

Make /queue/<css_id>/assign the default url to reach a judge's assign page #13913

hschallhorn opened this issue Apr 7, 2020 · 2 comments · Fixed by #14073
Assignees
@ajspotts
Labels
Feature: queue-table-view Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Bug User: Judge
Milestone
PI3-S7: Library o...

Comments

@hschallhorn
Copy link
Contributor

hschallhorn commented Apr 7, 2020 •
edited
Loading

In an effort to give judge assign queues human readable urls, we should make these urls the default url for these pages.

AC

  • When a judge navigates to their assign page from their dropdown, the url uses their css_id
  • When a judge navigates to their assign page using their user id, the url is updated to use their css_id
  • When clicking around the judge assign queue, the URL should not change to use the users id

Current issues

Incorrect URL
Screen Shot 2020-04-07 at 12 16 17 PM
Non updated URL
Screen Shot 2020-04-07 at 12 17 26 PM
Incorrect change of URL
ezgif-3-b06003fbb7f9
@hschallhorn hschallhorn added Feature: queue-table-view Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Type: Bug User: Judge Team: Echo 🐬 labels Apr 7, 2020
@ajspotts
Copy link
Contributor

ajspotts commented Apr 9, 2020

what is this chart?

1 | 
2 | ||||
3 | |||||||
5 | |
8 |

Why 2?

  • Can replicate some logic that was implemented in the original PR

Why 3?

  • unfamiliar with React routing
  • Updates in various places in the code to hit all AC, could be broken out into smaller PRs

Why 5?

  • General uncertainty

@yoomlam
Copy link
Contributor

yoomlam commented Apr 9, 2020

Related to #13433

@hschallhorn hschallhorn mentioned this issue Apr 20, 2020
Closed
@ajspotts ajspotts self-assigned this Apr 20, 2020
@ajspotts ajspotts mentioned this issue Apr 22, 2020
Merged
3 tasks
va-bot pushed a commit that referenced this issue Apr 29, 2020
@ajspotts
Make /queue/<css_id>/assign default url for judge assign page (#14073)
2810eaf 
Resolves #13913

### Description
`css_id` replaces `user_id` in the `queue/user/assign` url to make the URL more readable for users

### Acceptance Criteria
- [x] When a judge navigates to their assign page from their dropdown, the url uses their css_id
 - [ ] When a judge navigates to their assign page using their user id, the url is updated to use their css_id
- [x] When clicking around the judge assign queue, the URL should not change to use the users id

### Testing Plan
1. Sign in as `BVAAABSHIRE` and navigate to `http://localhost:3000/queue`
2. Ensure the assign page dropdown navigated to the assign page via the user's `css_id`
3. Navigate to the assign page with the user's `user_id` and endure the url properly updates to use the `css_id`: `http://localhost:3000/queue/BVAAABSHIRE/assign`
4. Ensure all of the `Assign Cases` links navigate to the correct url using the user's `css_id`

### User facing changes

#### Updated url in review page dropdown
#### Before
<img width="1439" alt="Screen Shot 2020-04-22 at 4 28 47 PM" src="https://user-images.githubusercontent.com/18618189/80032782-a9c07500-84b9-11ea-99da-019a312799de.png">

#### After
<img width="1433" alt="Screen Shot 2020-04-22 at 2 56 47 PM" src="https://user-images.githubusercontent.com/18618189/80032939-eab88980-84b9-11ea-9452-bd257cb974f3.png">

#### Updated url on assign page
#### Before
<img width="1439" alt="Screen Shot 2020-04-22 at 4 29 54 PM" src="https://user-images.githubusercontent.com/18618189/80033288-716d6680-84ba-11ea-939d-e40406d13170.png">

#### After
<img width="1439" alt="Screen Shot 2020-04-22 at 2 58 31 PM" src="https://user-images.githubusercontent.com/18618189/80033308-7a5e3800-84ba-11ea-80ed-fa5d7b2874a7.png">

#### Assign page links go to correct urls
#### Before
![ezgif com-video-to-gif](https://user-images.githubusercontent.com/18618189/80035603-4edd4c80-84be-11ea-9c13-f514c9f2b9c4.gif)

#### After
![ezgif com-video-to-gif (1)](https://user-images.githubusercontent.com/18618189/80036442-ba73e980-84bf-11ea-85e5-b2d7b7c3fee5.gif)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajspotts ajspotts

Labels
Feature: queue-table-view Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Bug User: Judge
Projects
None yet
Milestone
PI3-S7: Library of Congress (Innovati...
3 participants
@ajspotts @hschallhorn @yoomlam