Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give judge assign queues human readable urls #13433

Closed
1 task
hschallhorn opened this issue Feb 14, 2020 · 3 comments · Fixed by #13818
Closed
1 task

Give judge assign queues human readable urls #13433

hschallhorn opened this issue Feb 14, 2020 · 3 comments · Fixed by #13818
Assignees
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬

Comments

@hschallhorn
Copy link
Contributor

After work on #12423, users will be able to view the judge assign page of a judge. This url is formed as "/queue/<user_id>/assign". Users cannot be expected to know the caseflow user id of a judge. We should use their css id instead.

AC

  • Judge Assign queue url is "/queue/<user_css_id>/assign"
@hschallhorn hschallhorn added Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Product: caseflow-queue Team: Echo 🐬 Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. labels Feb 14, 2020
@kevmo
Copy link
Contributor

kevmo commented Feb 21, 2020

Make sure old URLs continue to workwhile defaulting to displaying new URLs.

@kevmo
Copy link
Contributor

kevmo commented Feb 21, 2020

Estimation: 3

What is this graph?

1 | 
2 | |||||
3 | |||||||||
5 | |
8 | 

Why a 2? Straightforward!!! This is what Rails does, "add one line, change another line, make a test..."

Why a 5? Could blow up because this URL is going through React Router. Pass through many different components. Front-end refactoring could dramatically expand the amount of work -- this is not just a backend change!

@yoomlam
Copy link
Contributor

yoomlam commented Mar 26, 2020

Since we're overloading <user_css_id> in the URL "/queue/<user_css_id>/assign", I'll have to assume that if <user_css_id> is an integer?, then it is a <user_id>. This means that a CSS_ID must never be an integer or coercible into an integer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants