Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle bad css_id when navigating to a judge assign queue #13911

Closed
1 task
hschallhorn opened this issue Apr 7, 2020 · 5 comments · Fixed by #14172
Closed
1 task

Handle bad css_id when navigating to a judge assign queue #13911

hschallhorn opened this issue Apr 7, 2020 · 5 comments · Fixed by #14172
Assignees
Labels
Feature: queue-table-view Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Bug User: Judge

Comments

@hschallhorn
Copy link
Contributor

hschallhorn commented Apr 7, 2020

As of #13433, when an invalid css_id is used in /queue/<css_id>/assign, the error is not handled.

Correct css_id
Screen Shot 2020-04-07 at 12 02 33 PM
Bad css_id
Screen Shot 2020-04-07 at 12 03 01 PM

// 20200420142400
// http://localhost:3000/queue/BVAAAAAAAABSHIRE/assign

{
  "errors": [
    {
      "status": 400,
      "title": "\"BVAAAAAAAABSHIRE\" is not a valid CSS_ID or user ID",
      "detail": "\"BVAAAAAAAABSHIRE\" is not a valid CSS_ID or user ID"
    }
  ]
}

This should instead redirect to our normal 404 page

AC

  • When the user navigates to an assign queue that does not exist, we should redirect them to our 404 page
@hschallhorn hschallhorn added Product: caseflow-queue Type: Bug User: Judge Feature: queue-table-view Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Team: Echo 🐬 labels Apr 7, 2020
@ajspotts
Copy link
Contributor

ajspotts commented Apr 9, 2020

what is this chart?

1 | ||
2 | ||||||||||
3 | 
5 | 
8 | 

Why 1?

  • Seems straightforward

Why 2?

  • I dunno how!
  • Assuming I can ask someone how this is done. (fail ActiveRecord::NotFound)

@yoomlam
Copy link
Contributor

yoomlam commented Apr 20, 2020

@hschallhorn
Copy link
Contributor Author

This is causing a sentry alert as well https://sentry.ds.va.gov/department-of-veterans-affairs/caseflow/issues/9927/

@yoomlam
Copy link
Contributor

yoomlam commented May 4, 2020

Using ActiveRecord::RecordNotFound shows this:
image

@yoomlam
Copy link
Contributor

yoomlam commented May 4, 2020

BEFORE AFTER
Screen Shot 2020-04-07 at 12 03 01 PM image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: queue-table-view Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Bug User: Judge
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants