Max CFI: Add support for other diagnostic codes #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaCoCo Test Coverage
|
dfitchett
commented
Apr 3, 2024
There was a problem hiding this comment.
Made from the Max Ratings for API tab from the max rating dataset in Sharepoint
There was a problem hiding this comment.
Any reason to keep the old lookup table in the data folder? If the idea is to support multiple versions, it might be good to document the breaking changes in get_max_ratings_by_code.
There was a problem hiding this comment.
Ah thats a good point. We can get rid of the old one. We don't currently have any need to support multiple versions.
gabezurita
pushed a commit
that referenced
this pull request
Dec 5, 2024
* Added new ratings for more diagnostic codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Currently, only the max rating for tinnitus (dc 6260) is available. This PR adds the remaining diagnostic codes for over 700 other rated disabilities.
Associated tickets or Slack threads:
How does this fix it?1
Adds support for other diagnostic codes
How to test this PR
Footnotes
Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩