Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2329 Create db connection to Alembic for the CC team #2808

Merged
merged 9 commits into from
Apr 5, 2024
Merged

#2329 Create db connection to Alembic for the CC team #2808

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d31ce63
Add domain-cc refs for alembic credentials
agile-josiah Mar 28, 2024
5129f70
Merge remote-tracking branch 'origin/develop' into josiah/#2329/domai…
agile-josiah Apr 3, 2024
ea47b81
Correct deployment.yaml charts
agile-josiah Apr 3, 2024
070ef77
Updated Description
agile-josiah Apr 3, 2024
11617e5
revert _posgres.tpl and create new alembic tpl
agile-josiah Apr 3, 2024
414db00
Change dir
agile-josiah Apr 3, 2024
4435cff
Change dir
agile-josiah Apr 3, 2024
afa842d
Add to templates but not named templates
agile-josiah Apr 3, 2024
afb3044
Merge branch 'develop' into josiah/#2329/domain-cc-alembic
agile-josiah Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions helm/_shared/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,4 @@ global:
targetPort: 5432
databaseName: vro
schemaName: claims
domainCcSchemaName: domain-cc
16 changes: 16 additions & 0 deletions helm/domain-cc/templates/_alembicdb.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{{/*
For Alembic to connect to Postgres Domain-cc DB schema
*/}}
{{- define "domainCc.alembic.envVars" -}}
- name: DOMAIN_CC_USER
valueFrom:
secretKeyRef:
name: domain-cc-db
key: DOMAIN_CC_USER
- name: DOMAIN_CC_PW
valueFrom:
secretKeyRef:
name: domain-cc-db
key: DOMAIN_CC_PW
- name: ALEMBIC_SCHEMA
value: {{ .Values.global.service.db.domainCcSchemaName }}
2 changes: 2 additions & 0 deletions helm/domain-cc/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ spec:
{{- include "vro.commonEnvVars" . | nindent 12 }}
{{- include "vro.mqClient.envVars" . | nindent 12 }}
{{- include "vro.redisClient.envVars" . | nindent 12 }}
{{- include "domainCc.alembic.envVars" . | nindent 12 }}
{{- include "vro.postgresUrl" . | nindent 12 }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYSA @tyler-spangler6 this allows us to make use of DB_URL from env vars (e.g. os.environ.get() in python)
See linked file here.

resources:
requests:
cpu: 150m
Expand Down