#2329 Create db connection to Alembic for the CC team #2808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
JaCoCo Test Coverage
|
agile-josiah
changed the title
tejans24
approved these changes
Apr 3, 2024
msnwatson
suggested changes
Apr 3, 2024
msnwatson
approved these changes
Apr 3, 2024
lukey-luke
reviewed
Apr 3, 2024
| @@ -29,6 +29,8 @@ spec: | |||
| {{- include "vro.commonEnvVars" . | nindent 12 }} | |||
| {{- include "vro.mqClient.envVars" . | nindent 12 }} | |||
| {{- include "vro.redisClient.envVars" . | nindent 12 }} | |||
| {{- include "domainCc.alembic.envVars" . | nindent 12 }} | |||
| {{- include "vro.postgresUrl" . | nindent 12 }} | |||
There was a problem hiding this comment.
FYSA @tyler-spangler6 this allows us to make use of DB_URL from env vars (e.g. os.environ.get() in python)
See linked file here.
lukey-luke
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Draft pr for dev: CC team needs to connect to the rds db for use with alembic to create tables and
Associated tickets or Slack threads:
How does this fix it?1
Adds refs to the secrets in lens, currently only in dev
Footnotes
Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩