Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Frequently referenced github actions to use node20 #2649

Merged
merged 7 commits into from
Feb 27, 2024

Conversation

nelsestu
Copy link
Contributor

This PR updates the two most frequently referenced github action job references to use the node20 upgrade in each of the job definitions. For actions/checkout and actions/setup-java the default runtime for node will now use node20, rather then node16

What was the problem?

When ever a github action used the checkout@v3 or setup-java@v3 job references, it would result in a warning about node 16 being deprecated.

How does this fix it?1

By upgrading to use checkout@v4 and setup-java@v4 we'll be upgrading the actions to use node20 and we'll no longer have so many node 16 deprecation warnings.

How to test this PR

  • Observe fewer warnings in the action output of our workflows

Footnotes

  1. Pull-Requests guidelines. If PR is significant, update Current Software State wiki page.

…references to use the node20 upgrade in each of the job definitions. For actions/checkout and actions/setup-java the default runtime for node will now use node20, rather then node16
@nelsestu nelsestu requested a review from a team as a code owner February 21, 2024 15:55
Copy link
Contributor

github-actions bot commented Feb 21, 2024

Test Results

149 tests  ±0   149 ✅ ±0   47s ⏱️ -1s
 39 suites ±0     0 💤 ±0 
 39 files   ±0     0 ❌ ±0 

Results for commit 0a4c9f5. ± Comparison against base commit 6299185.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 21, 2024

JaCoCo Test Coverage

There is no coverage information present for the Files changed

Total Project Coverage 76.53%

Copy link
Contributor

@Ponnia-M Ponnia-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and these are the same changes I made locally.

@Ponnia-M Ponnia-M merged commit acc840d into develop Feb 27, 2024
1 check passed
@Ponnia-M Ponnia-M deleted the upgrade-action-node20 branch February 27, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants