Skip to content

Commit

Permalink
Update Frequently referenced github actions to use node20 (#2649)
Browse files Browse the repository at this point in the history
This PR updates the two most frequently referenced github action job references to use the node20 upgrade in each of the job definitions.  For actions/checkout and actions/setup-java the default runtime for node will now use node20, rather then node16

Co-authored-by: Erik Nelsestuen <[email protected]>
Co-authored-by: Teja <[email protected]>
Co-authored-by: Cheng <[email protected]>
Co-authored-by: Ponnia <[email protected]>
  • Loading branch information
5 people authored Feb 27, 2024
1 parent 6299185 commit acc840d
Show file tree
Hide file tree
Showing 21 changed files with 33 additions and 33 deletions.
4 changes: 2 additions & 2 deletions .github/actions/setup-vro/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ runs:
using: composite
steps:
- name: "Install Java"
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
distribution: temurin
java-version: '17'
# "When using gradle-build-action we recommend that you
# not use actions/cache or actions/setup-java@v3 to explicitly
# not use actions/cache or actions/setup-java@v4 to explicitly
# cache the Gradle User Home"
# cache: 'gradle'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/api-gateway-integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: "Checkout source code"
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: "Build the images"
uses: ./.github/actions/build-images
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/bie-kafka-end2end-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: 'Checkout source code'
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: "Checkout abd-vro-dev-secrets repo"
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
# Checkout using a PAT so that we can access the internal repo
token: ${{ secrets.ACCESS_TOKEN_CHECKOUT_INTERNAL_REPO }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- ruby
steps:
- name: "Checkout source code"
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Set up VRO build env
uses: ./.github/actions/setup-vro
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/container-healthchecks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:

steps:
- name: "Checkout source code"
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: "Checkout abd-vro-dev-secrets repo"
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
# Checkout using a PAT so that we can access the internal repo
token: ${{ secrets.ACCESS_TOKEN_CHECKOUT_INTERNAL_REPO }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/create-gh-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: "Checkout source code"
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: "Check if release already exists"
id: check-release
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/create-release-tag.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: "Install Java"
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
distribution: temurin
java-version: '17'
# "When using gradle-build-action we recommend that you
# not use actions/cache or actions/setup-java@v3 to explicitly
# not use actions/cache or actions/setup-java@v4 to explicitly
# cache the Gradle User Home"
# cache: 'gradle'
- name: "Setup Gradle"
Expand All @@ -37,7 +37,7 @@ jobs:
# https://github.com/gradle/actions/setup-gradle@v3#removing-unused-files-from-gradle-user-home-before-saving-to-cache
gradle-home-cache-cleanup: true
- name: "Checkout source code"
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
# Checkout using a PAT so that we can do `git push` later
token: ${{ secrets.ACCESS_TOKEN_PUSH_TO_DEVELOP }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy-secrets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
password: ${{ secrets.GITHUB_TOKEN }}

- name: "Checkout source code"
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: "Build image"
run: |
Expand Down Expand Up @@ -98,7 +98,7 @@ jobs:
chmod go-rwx ~/.kube/config
- name: "Checkout source code"
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: "Deploy runner (in dev)"
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ee-ep-merge-end-to-end.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ jobs:
steps:

- name: 'Checkout source code'
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: "Checkout abd-vro-dev-secrets repo"
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
# Checkout using a PAT so that we can access the internal repo
token: ${{ secrets.ACCESS_TOKEN_CHECKOUT_INTERNAL_REPO }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/fast-forward-develop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: "Checkout source code"
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
# Checkout using a PAT so that we can do `git push` later
token: ${{ secrets.ACCESS_TOKEN_PUSH_TO_DEVELOP }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint-gh-actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
name: Lint GitHub Actions workflows
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: "Set up actionlint"
id: get_actionlint
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/lint-gradle-files.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ jobs:
lint-gradle-files:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: "Install Java"
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
distribution: temurin
java-version: '17'
# "When using gradle-build-action we recommend that you
# not use actions/cache or actions/setup-java@v3 to explicitly
# not use actions/cache or actions/setup-java@v4 to explicitly
# cache the Gradle User Home"
# cache: 'gradle'
- name: "Setup Gradle"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/mirror-on-test-success.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: "Checkout source code"
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: "Mirror to internal repo"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/mirror.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: "Checkout source code"
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: "Mirror to internal repo"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/secrel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ jobs:
echo "publish_mode: ${{ steps.image-props.outputs.publish_mode }}"
- name: "Checkout source code"
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
# Checkout using a PAT so that we can do `git push` later in publish-images
token: ${{ secrets.ACCESS_TOKEN_PUSH_TO_DEVELOP }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/svc-bgs-api-integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
ruby-version: '3.3.0'

- name: 'Checkout source code'
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: 'Build the images'
uses: ./.github/actions/build-images
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/svc-bip-api-integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: 'Checkout source code'
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: "Checkout abd-vro-dev-secrets repo"
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
# Checkout using a PAT so that we can access the internal repo
token: ${{ secrets.ACCESS_TOKEN_CHECKOUT_INTERNAL_REPO }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test-code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:

steps:
- name: "Checkout source code"
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: "Set up VRO build env"
uses: ./.github/actions/setup-vro
Expand Down Expand Up @@ -95,7 +95,7 @@ jobs:

steps:
- name: "Checkout source code"
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
# Need to fetch more than 1 deep to see changes
fetch-depth: 2
Expand Down Expand Up @@ -129,7 +129,7 @@ jobs:

steps:
- name: "Checkout source code"
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
# Need to fetch more than 1 deep to see changes
fetch-depth: 2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ jobs:
fi
- name: "Checkout source code"
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: "Slack thread: Post deploying message"
# Post in thread to reduce clutter in Slack
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/xample-integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: "Checkout source code"
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: "Build the images"
uses: ./.github/actions/build-images
Expand Down
2 changes: 1 addition & 1 deletion domain-rrd/github/rrd-end2end-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: "Checkout source code"
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: "Build the images"
uses: ./.github/actions/build-images
Expand Down

0 comments on commit acc840d

Please sign in to comment.