Add cancellation as claim note through VRO's svc-bgs-api #2315
Conversation
…egration tests to create the required exchanges along with the queues.
| @@ -62,18 +62,6 @@ jobs: | |||
| # Quit after 60 seconds | |||
| retries: 30 | |||
|
|
|||
| # Temporary step added to avoid condition where bipApiExchange is not yet created. | |||
There was a problem hiding this comment.
This is no longer necessary as the integration tests declare the bipApiExchange
| f"error=\'{error}\'") | ||
| self.job.error(self.job.state, error) | ||
| f"error=\"{jsonable_encoder(error)}\"") | ||
| self.job.error(error if type(error) is list else [error]) |
There was a problem hiding this comment.
Prefer isinstance(error, list) over type(error) is list to support subclasses.
| self.state = JobState.COMPLETED_ERROR | ||
| if self.messages is None: | ||
| self.messages = [] | ||
| self.messages.append(message) | ||
| for message in messages: | ||
| self.messages.append(message) |
There was a problem hiding this comment.
This can be self.messages.extend(messages)
| @@ -52,4 +65,6 @@ class ClientName(str, Enum): | |||
| os.environ.get("CREATE_CLAIM_CONTENTIONS_RESPONSE") or "createClaimContentionsResponseQueue", | |||
| ClientName.CANCEL_CLAIM: | |||
| os.environ.get("CANCEL_CLAIM_RESPONSE") or "cancelClaimResponseQueue", | |||
| ClientName.BGS_ADD_CLAIM_NOTE: | |||
| os.environ.get("ADD_CLAIM_NOTE_RESPONSE") or "add-note-response", | |||
There was a problem hiding this comment.
Is it too late to switch these to camel-case? 😅
| @@ -48,8 +56,10 @@ class EpMergeMachine(StateMachine): | |||
| | running_merge_contentions.to(completed_error, cond="has_error") | |||
| | running_move_contentions_to_pending_claim.to(running_cancel_ep400_claim, unless="has_error") | |||
| | running_move_contentions_to_pending_claim.to(completed_error, cond="has_error") | |||
| | running_cancel_ep400_claim.to(completed_success, unless="has_error") | |||
| | running_cancel_ep400_claim.to(running_add_claim_note_to_ep400, unless="has_error") | |||
There was a problem hiding this comment.
I thought the plan was to add a claim note when merging failed, not on success?
There was a problem hiding this comment.
Nope. The plan is to add a claim note as part of the happy path. See #2161. The claim note is being added after the claim is cancelled that way the cancellation reason for the claim will show in VBMS. 👍
JaCoCo Test Coverage
|
What was the problem?
EP Merge needs to add a claim note to the EP400 upon canceling the claim.
Associated tickets or Slack threads:
How does this fix it?1
Adds step in state machine to add a claim note with the cancellation reason to the EP400 claim.
How to test this PR
Footnotes
Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩