chore(build): disable codecov status #776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right so it shows up in the checks for the main branch which was not intentional. Maybe we should set
|
|
Informational mode sounds good 👍 Updated the PR. |
ry
approved these changes
Mar 2, 2021
|
This is landed as part of #775 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables the commit status from codecov.io.
Codecov sends failed commit status to the branch when the coverage rate is decreased. Higher coverage rate is generally a good thing, but marking the commit as
failurebecause of the decreased coverage doesn't make sense to our use case.ref: https://docs.codecov.io/docs/commit-status#disabling-a-status