-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(path): update test cases for canary #775
Conversation
Shouldn't we be fixing the code instead of disabling tests? |
@kitsonk I first thought of that, but the CI runs with both 1.7.5 and canary until 1.8 released. So I think it's difficult to update it to pass with both versions. |
I think we should disable this test in stable CI then and fix it in canary. It working on canary is more important than it working on stable IMO. |
hmm... OK, I'll try it. |
Introduced isCanary flag ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - lets revert this right after 1.8 is released.
This PR disables some test assertions of
std/path
which started failing with canary today.related to: denoland/deno#9276
closes #774