Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(path): update test cases for canary #775

Merged
merged 6 commits into from
Mar 2, 2021

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Mar 2, 2021

This PR disables some test assertions of std/path which started failing with canary today.

related to: denoland/deno#9276

closes #774

@kitsonk
Copy link
Contributor

kitsonk commented Mar 2, 2021

Shouldn't we be fixing the code instead of disabling tests?

@kt3k
Copy link
Member Author

kt3k commented Mar 2, 2021

@kitsonk I first thought of that, but the CI runs with both 1.7.5 and canary until 1.8 released. So I think it's difficult to update it to pass with both versions.

@lucacasonato
Copy link
Member

@kitsonk I first thought of that, but the CI runs with both 1.7.5 and canary until 1.8 released. So I think it's difficult to update it to pass with both versions.

I think we should disable this test in stable CI then and fix it in canary. It working on canary is more important than it working on stable IMO.

@kt3k
Copy link
Member Author

kt3k commented Mar 2, 2021

I think we should disable this test in stable CI then and fix it in canary. It working on canary is more important than it working on stable IMO.

hmm... OK, I'll try it.

@kt3k
Copy link
Member Author

kt3k commented Mar 2, 2021

Introduced isCanary flag (const isCanary = /\d\.\d\.\d\+[0-9a-f]{7}/.test(Deno.version.deno)), and also merged #776, which is necessary to make CI green.

@kt3k kt3k changed the title chore(path): disable some failed test test(path): update test cases for canary Mar 2, 2021
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - lets revert this right after 1.8 is released.

@kt3k kt3k merged commit 3b0dd8a into denoland:main Mar 2, 2021
@kt3k kt3k deleted the chore/disable-some-path-assertions branch March 2, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 test cases fail with canary (2021-03-02)
3 participants