Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(fs): uncaught FS errors in web #6135

Merged
merged 7 commits into from
Oct 24, 2024
Merged

refactor(fs): uncaught FS errors in web #6135

merged 7 commits into from
Oct 24, 2024

Conversation

QuixThe2nd
Copy link
Contributor

Fixes #6132

@QuixThe2nd QuixThe2nd requested a review from kt3k as a code owner October 22, 2024 09:18
@CLAassistant
Copy link

CLAassistant commented Oct 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the fs label Oct 22, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.58%. Comparing base (5cd3b5d) to head (7036e86).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
fs/eol.ts 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6135      +/-   ##
==========================================
- Coverage   96.58%   96.58%   -0.01%     
==========================================
  Files         536      536              
  Lines       40679    40684       +5     
  Branches     6110     6110              
==========================================
+ Hits        39291    39294       +3     
- Misses       1344     1345       +1     
- Partials       44       45       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@QuixThe2nd QuixThe2nd changed the title Fix uncaught error in FS.ensure_symlink fix(fs): uncaught error in FS.ensure_symlink Oct 22, 2024
kt3k
kt3k reviewed Oct 22, 2024
View reviewed changes
fs/ensure_symlink.ts Outdated Show resolved Hide resolved
@kt3k
Copy link
Member

kt3k commented Oct 22, 2024

@QuixThe2nd Can you sign the CLA from the above link?

kt3k
kt3k approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

The current CI (lint) failure is irrelevant to this change. The maintainers will fix them and land this PR after that.

@QuixThe2nd
Copy link
Contributor Author

@QuixThe2nd Can you sign the CLA from the above link?

Done! Thanks for dealing with this so fast :)

@QuixThe2nd QuixThe2nd changed the title fix(fs): uncaught error in FS.ensure_symlink fix(fs): uncaught error in FS Oct 22, 2024
@QuixThe2nd
Copy link
Contributor Author

I noticed a few other files had the same issue.

@QuixThe2nd QuixThe2nd changed the title fix(fs): uncaught error in FS fix(fs): uncaught FS errors in web Oct 22, 2024
@QuixThe2nd QuixThe2nd mentioned this pull request Oct 23, 2024
Merged
@kt3k kt3k changed the title fix(fs): uncaught FS errors in web refactor(fs): uncaught FS errors in web Oct 24, 2024
@kt3k kt3k merged commit c0427a0 into denoland:main Oct 24, 2024
19 checks passed
@QuixThe2nd QuixThe2nd mentioned this pull request Nov 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
fs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fs.ensure_symlink throwing error in browser
3 participants
@QuixThe2nd @CLAassistant @kt3k