fs.ensure_symlink throwing error in browser

[QuixThe2nd]

Describe the bug

On line 8 of ensure_symlink.ts on-import the script checks if the user is on windows (const isWindows = Deno.build.os === "windows";). Deno however is undefined in browser throwing a fatal error.

Steps to Reproduce

1. Build project with:

import * as esbuild from "npm:esbuild";
await esbuild.build({ plugins: [...denoPlugins()], entryPoints: ["./src/in.ts"], outfile: "./dist/out.js", bundle: true, format: "esm", platform: "browser" });

2. Import in web:

    <script type="module" src="hydrafiles-web.esm.js"></script>
    <script type="module">
    import Hydrafiles from './hydrafiles-web.esm.js';
    </script>

3. Error in browser logs

Expected behavior

A check should be done before Deno.build.os === "windows" to first check if user is in Deno environment. For example:

const isWindows = window !== undefined && Deno.build.os === "windows";

Environment

• OS: N/A
• deno version: 2.0
• std version: 0.221.0

[QuixThe2nd]

I would have sent a pull request, but I am new to Deno. I'm not confident the error isn't my fault.

[kt3k]

What is the expected behavior of ensureSymlink in browser?

[QuixThe2nd]

What is the expected behavior of ensureSymlink in browser?

If it's imported in a script that runs in both browser and Deno, it throws an error on import. It should instead throw the error when ensureSymlink is called.

[kt3k]

It should instead throw the error when ensureSymlink is called.

Ah, ok. That makes sense to me.