Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(assert): revert "handle assertStrictEquals(-0, +0) correctly" #4718

Merged
merged 1 commit into from
May 13, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented May 13, 2024

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.44%. Comparing base (8c87b7f) to head (c297ba2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4718      +/-   ##
==========================================
- Coverage   91.44%   91.44%   -0.01%     
==========================================
  Files         480      480              
  Lines       37324    37318       -6     
  Branches     5320     5316       -4     
==========================================
- Hits        34132    34126       -6     
  Misses       3136     3136              
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 6769253 into main May 13, 2024
12 checks passed
@iuioiua iuioiua deleted the revert-4715 branch May 13, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants