assertStrictEquals(-0, +0) should not throw

[rherrmann]

Describe the Bug
According to the Strict Equality Comparison Algorithm of the Javascript standard, -0 and +0 are considered equal.

Assuming that assertStrictEquals is meant to assert equality in the sense of actual === expected, it should not throw when passing -0 and +0 for actual and expected.

Steps to Reproduce

import { assert, assertStrictEquals } from "https://deno.land/[email protected]/assert/mod.ts";

assert(-0 === +0); // passes
assertStrictEquals(-0, +0); // fails

Expected Behavior
assertStrictEquals(-0, +0) should not throw.

Environment

• OS: macOS
• deno version: 1.43.2
• std version: 0.224

[kt3k]

Note: In Node.js, +0 and -0 are not equal with assert.strictEqual assertion. I'm not sure the suggested behavior is expected

[iuioiua]

That's a fair point. Should we adhere to ECMA's definition of strict equality (===) or mimic Node's implementation, which uses Object.is()?

[kt3k]

Jest and Vitest also follow what Node.js does. The below examples throw in jest and vitest:

Jest

expect(+0).toStrictEqual(-0);

Vitest

import { expect, test } from 'vitest'
expect(+0).toStrictEqual(-0);

[iuioiua]

Ok. I'll revert and instead add a note explaining the behavior.

[iuioiua]

fix(assert): handle assertStrictEquals(-0, +0) correctly #4715

See #4718