chore: replace deprecated typeByExtension() in content_type.ts
#3727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, these were the types of issues I was hoping to catch when I first created the issue. I’m not certain what to do here. Either way, can you please fix the failing tests? |
Yes, my mistake. I forgot to import types. |
Signed-off-by: Oscar <[email protected]>
0scvr
force-pushed
the
deprecated-typeByExtension
branch
from
e8aa8c5
to
76e9a1d
Compare
iuioiua
changed the title
typeByExtension in content_type.tstypeByExtension() in content_type.ts
iuioiua
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced call to deprecated
typeByExtensionincontent_type.tsin favour of privatetypeByExtensionfunction.See #3718
Not sure if this is what you were looking for. Seems odd to deprecate typeByExtension when it is needed by content type and would need to be reimplemented for content type when removed.