Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracking: cleanup deprecated APIs #3718

Closed
7 tasks done
iuioiua opened this issue Oct 25, 2023 · 5 comments
Closed
7 tasks done

tracking: cleanup deprecated APIs #3718

iuioiua opened this issue Oct 25, 2023 · 5 comments
Labels
good first issue Good for newcomers

Comments

@iuioiua
Copy link
Contributor

iuioiua commented Oct 25, 2023

Upon deprecating an API, removing its use throughout the Standard Library is best. This exposes the implications of the deprecation and is an exercise in what the migration will involve for devs using the API. I think it's best to have this done before removal to weed out any potential issues early. These are some of the deprecated APIs I've noticed that are still in use throughout the Standard Library:

Note: I've done my best only to include deprecated APIs used in other stable APIs or deprecated APIs with some time till removal. Please let me know if I've missed any or included some needlessly.

@iuioiua iuioiua added the good first issue Good for newcomers label Oct 25, 2023
@0scvr
Copy link
Contributor

0scvr commented Oct 25, 2023

I have gone through the code quickly and it seems that most of these functions are only used in deprecated functions/types (therefore not needing to be replaced) or in test files.

@iuioiua
Copy link
Contributor Author

iuioiua commented Oct 25, 2023

Yes, I've included test cases deliberately. Either way, to be sure, I double-checked my list, added reasoning behind each inclusion, and removed readerFromIterable() and writeAllSync(). Thanks for checking!

@git001
Copy link

git001 commented Oct 30, 2023

I'm getting confused when I tak a look into Deno.Buffer Deno.Buffer which links to Buffer and this mention this.

Use Web Streams instead

I can't find the Web Streams in the doc. Please can be linked the Web Streams doc to the deprecated buffer doc, thanks.

@iuioiua
Copy link
Contributor Author

iuioiua commented Oct 30, 2023

That's a good point. I'll fix this once I get a chance.

@iuioiua
Copy link
Contributor Author

iuioiua commented Nov 28, 2023

I reviewed the list, and it appears that these deprecated APIs are no longer used in stable APIs. Work done! Thank you to those who helped.

@iuioiua iuioiua closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants