-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracking: cleanup deprecated APIs #3718
Comments
I have gone through the code quickly and it seems that most of these functions are only used in deprecated functions/types (therefore not needing to be replaced) or in test files. |
Yes, I've included test cases deliberately. Either way, to be sure, I double-checked my list, added reasoning behind each inclusion, and removed |
I'm getting confused when I tak a look into
I can't find the |
That's a good point. I'll fix this once I get a chance. |
I reviewed the list, and it appears that these deprecated APIs are no longer used in stable APIs. Work done! Thank you to those who helped. |
Upon deprecating an API, removing its use throughout the Standard Library is best. This exposes the implications of the deprecation and is an exercise in what the migration will involve for devs using the API. I think it's best to have this done before removal to weed out any potential issues early. These are some of the deprecated APIs I've noticed that are still in use throughout the Standard Library:
deferred()
(which was deprecated in BREAKING(async): deprecatedeferred()
in favor ofPromise.withResolvers()
#3758)BytesList()
(to be removed in 0.205.0, but is being used inreadDelim()
, which is being removed in v1.0.0)toHashString()
(in JSDocs)StringReader()
(used in std/csv test, which is stable)typeByExtension()
(used in std/media_type, which is stable)iterateReader()
(used in std/http, which is stable)readableStreamFromReader()
(used in std/csv test, which is stable)Note: I've done my best only to include deprecated APIs used in other stable APIs or deprecated APIs with some time till removal. Please let me know if I've missed any or included some needlessly.
The text was updated successfully, but these errors were encountered: