Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated BytesList() in readDelim() #3726

Merged
merged 2 commits into from
Oct 28, 2023
Merged

chore: remove deprecated BytesList() in readDelim() #3726

merged 2 commits into from
Oct 28, 2023

Conversation

0scvr
Copy link
Contributor

@0scvr 0scvr commented Oct 26, 2023

Removed use of deprecated BytesList in readDelim in favour of Uint8Array.

See #3718

@0scvr 0scvr requested a review from kt3k as a code owner October 26, 2023 10:20
@github-actions github-actions bot added the io label Oct 26, 2023
@iuioiua
Copy link
Contributor

iuioiua commented Oct 26, 2023

Hm, I would’ve thought concat() would be needed here. WDYT, @kt3k?

iuioiua
iuioiua suggested changes Oct 28, 2023
View reviewed changes
io/read_delim.ts Outdated Show resolved Hide resolved
@0scvr 0scvr force-pushed the cleanup-deprecated-byteslist branch from 37f501a to aa4a27e Compare October 28, 2023 15:41
@0scvr 0scvr force-pushed the cleanup-deprecated-byteslist branch from aa4a27e to 1908e75 Compare October 28, 2023 15:42
@iuioiua iuioiua changed the title chore: remove deprecated BytesList in readDelim chore: remove deprecated BytesList() in readDelim() Oct 28, 2023
iuioiua
iuioiua approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a tweak, and now, LGTM! Thank you.

@iuioiua iuioiua merged commit 33684a2 into denoland:main Oct 28, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0scvr @iuioiua