Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): add process.execPath #1748

Merged
merged 1 commit into from
Dec 23, 2021
Merged

feat(node): add process.execPath #1748

merged 1 commit into from
Dec 23, 2021

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Dec 23, 2021

This PR adds process.execPath in std/node.

This resolves one of the issues in running npm in compat mode. ref: denoland/deno#13187

bartlomieju
bartlomieju approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm still not convinced that we should require --allow-read flag to get this value

@kt3k
Copy link
Member Author

kt3k commented Dec 23, 2021

I'm still not convinced that we should require --allow-read flag to get this value

There was also a similar question before. #749 (comment)

@kt3k kt3k merged commit 1f7beb1 into denoland:main Dec 23, 2021
@kt3k kt3k deleted the feat/process-exec-path branch December 23, 2021 15:54
@kt3k kt3k mentioned this pull request Dec 23, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kt3k @bartlomieju