compat: tracking issue for running npm

[kt3k]

npm (show help message) ✅

• Cannot read properties of undefined at process.execPath.toUpperCase() npm/lib/npm.js:213 feat(node): add process.execPath std#1748
• npm ERR! Exit handler never called! at the end of the execution node: 'exit' event is emitted twice when process.exit() is called std#1752

npm init

• Not Implemented at vm.runInThisContext call promzard/promzard.js:86 in promzard feat(node): add vm.runInThisContext std#1747
• Error when ./bin or ./node_modules doesn't exist. Probably something's wrong with readdir error handling node: fs.readdir doesn't handle error correctly when the directory doesn't exist std#1756
• npm ERR! Exit handler never called! at the end of the execution node: 'exit' event is emitted twice when process.exit() is called std#1752

npm install <dep>

• TypeError: req.abort is not function minipass-fetch/lib/index.js:73 in minipass-fetch
• npm ERR! request to https://***:[email protected]/pretty-bytesnullnullnullnullnullnull failed, reason: this.cb is not a function looks enigmatic. Something's wrong with https.request?

[bartlomieju]

When trying to run npm init I get:

Not implemented: process.on("uncaughtException")
Not implemented: process.on("unhandledRejection")
npm ERR! Cannot assign to read only property 'name' of function 'class Init extends BaseCommand {
npm ERR!   static description = 'Create a package.json file'
npm ERR!   static params = ['yes', ...<omitted>...
npm ERR! }'

[kt3k]

@bartlomieju I can't reproduce the above error on my machine. How do you execute npm?

[kt3k]

BTW I use [email protected]. What version do you use?

[bartlomieju]

@bartlomieju I can't reproduce the above error on my machine. How do you execute npm?

I got it cloned locally, and I execute it like: deno run --unstable -A --compat --no-check index.js init (I set up DENO_NODE_COMPAT_URL prior to execution). The version is 8.1.4

[bartlomieju]

npm ERR! request to https://***:[email protected]/pretty-bytesnullnullnullnullnullnull failed, reason: this.cb is not a function looks enigmatic. Something's wrong with https.request?

This seems like an issue with ClientRequest being a class in std/node, while in Node it's written in ES5 function class syntax. I'm not 100% sure, but it seems similar to other issues we had when using class based approach.

[bartlomieju]

npm ERR! request to https://***:[email protected]/pretty-bytesnullnullnullnullnullnull failed, reason: this.cb is not a function looks enigmatic. Something's wrong with https.request?

This seems like an issue with ClientRequest being a class in std/node, while in Node it's written in ES5 function class syntax. I'm not 100% sure, but it seems similar to other issues we had when using class based approach.

this.cb being null is actually valid in Node code, however we're handling it not properly. I have no idea why the URL for fetch is mangled so badly, I've been debugging this issue for the past 3 hours and haven't made any progress.

[bartlomieju]

npm install should now work with latest deno_std. Thanks @AaronO for help.

[kt3k]

Wow. Great! Thanks! @AaronO

[kt3k]

Tried on my machine. I still see this kind of error (with [email protected] & 7.x):

$ npm install pretty-bytes
Not implemented: process.on("uncaughtException")
Not implemented: process.on("unhandledRejection")
error: Uncaught (in promise) TypeError: w.write is not a functiondDeps
    nwritten += await w.write(arr.subarray(nwritten));
                        ^
    at writeAll (file:///Users/kt3k/denoland/deno_std/streams/conversion.ts:350:25)
    at innerWrite (file:///Users/kt3k/denoland/deno_std/node/_fs/_fs_write.js:20:12)
    at Object.write (file:///Users/kt3k/denoland/deno_std/node/_fs/_fs_write.js:23:3)

What version have you tested?

[kt3k]

nevermind. I found the cause. Will send a PR to std soon

[kt3k]

denoland/std#1832

[bartlomieju]

Just checked again, and I still can't run latest version of npm (v8):

❯ deno run --compat --unstable -A ../cli/bin/npm-cli.js install
Not implemented: process.on("uncaughtException")
Not implemented: process.on("unhandledRejection")
npm ERR! Cannot assign to read only property 'name' of function 'class Install extends ArboristWorkspaceCmd {
npm ERR!   static description = 'Install a package'
npm ERR!   static name = 'instal...<omitted>...
npm ERR! }'

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/ib/.npm/_logs/2022-02-08T02_04_41_400Z-debug-0.log