Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(action): auto-discovery of deno.json and auto-populate defaults #351

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

lowlighter
Copy link
Contributor

@lowlighter lowlighter commented Dec 19, 2024

Closes #350

PS: the diff is not that huge, most of the changed files are due to the addition of a jsonc parser package in the node_module directory

Features:

  • Add a new option deno-config
    • Auto-discovery of deno.json/deno.jsonc from the root file
  • If the deno config file exists, then
    • project defaults to "deploy.project"
    • entrypoint defaults to "deploy.entrypoint"
    • exclude defaults to "deploy.exclude"
    • include defaults to "deploy.include"
    • import-map defaults to "importMap"
      • If it contains a "import" field, it is saved as JSON to import-map-autogen-temp, allowing use of JSONC deno config file since using them directly in import-map would cause parsing issues if there is comments

Changes:

  • Added jsonc as dependency
  • Modified the workflow to have the test project as variable so it's easier for contributor to test their code
  • Updated docs about the new deno-config feature
  • Added a new test case to cover this new feature

Side note: since the deno config is discovered it allows for a really clean workflow, and also if user test their deployment from the CLI version (which populates the "deploy" section of deno config) then they'll have the same "experience" on the GA version.

It may or may not be considered a breaking change, since the config file was totally ignored before, so it could change they way if work if inputs were explicit

    steps:
      - name: Clone repository
        uses: actions/checkout@v4
      # ...
      - name: Deploy to Deno Deploy
        uses: denoland/deployctl@v1

@CLAassistant
Copy link

CLAassistant commented Dec 19, 2024

CLA assistant check
All committers have signed the CLA.

@lowlighter lowlighter marked this pull request as ready for review December 19, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deployctl github action is missing a lot of features from the cli version
2 participants