Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployctl github action is missing a lot of features from the cli version #350

Open
lowlighter opened this issue Dec 16, 2024 · 0 comments · May be fixed by #351
Open

deployctl github action is missing a lot of features from the cli version #350

lowlighter opened this issue Dec 16, 2024 · 0 comments · May be fixed by #351

Comments

@lowlighter
Copy link
Contributor

The GA significantly deviates from the deployctl, causing a lot of headaches and the need of hacks to make it work with "modern deno":

  • no auto-discovery of deno.jsonc
  • needs to manually re-specify project, entrypoint and other flags despite being present in deno.jsonc (required by action.yml)
  • import map does not default to deno.jsonc
  • using deno.jsonc as import map can error as it expects JSON (not JSONC)
  • a "simple translation" of deno.jsonc to imports.json doesn't work oob because it cannot resolve resolves sub-exports (e.g. "@x/y/z")
  • diverging options between cli and GA (not all options are available, for example passing env vars)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant