add support for deno 1.25.0 buffer ffi type #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zifeo
approved these changes
Aug 29, 2022
|
@tsar-boomba I think we should update version to 1.25.0 deno_bindgen/.github/workflows/ci.yml Lines 13 to 15 in 1cc5d34 |
littledivy
reviewed
Sep 1, 2022
zifeo
approved these changes
Sep 1, 2022
There was a problem hiding this comment.
@tsar-boomba Tested successfully, support is now complete 🎉 Can you maybe reformat with deno fmt? We should add this to the pipeline.
tsar-boomba
requested review from
zifeo and
littledivy
and removed request for
zifeo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses buffer instead of pointer to align with deno 1.25.0