core: introduce extensions #9800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
Mar 16, 2021
core/runtime_modules.rs
Outdated
| // ``` | ||
| // fn web_modules(args: WebModuleArgs) -> MultiModule { | ||
| // MultiModule::new(vec![deno_url::init(), deno_fetch::init(...), ...]) | ||
| // } |
|
Nice! I fully support this effort. If you can get the existing op crates working and the tests pass, I'm rather confident that this will generalize to future needs. I think it will be challenging tho. |
Also rewrite their `::init()` to return JsRuntimeModules
Is less verbose, auto-stringifies op-names to avoid types, ...
Replaces PureJsModule/SimpleModule/SimpleOpModule with a single simpler struct
ry
reviewed
Mar 17, 2021
ry
reviewed
Mar 17, 2021
ry
reviewed
Mar 17, 2021
ry
reviewed
Mar 17, 2021
ry
reviewed
Mar 17, 2021
bartlomieju
reviewed
Mar 18, 2021
bartlomieju
reviewed
Mar 18, 2021
Don't check bytes sent/received since those are irrelevant and not functional since serde_v8 op-layer rewrite
bartlomieju
reviewed
Apr 25, 2021
There was a problem hiding this comment.
After more thought I really do think we shouldn't go with the name "extensions". A couple reasons:
- term "op crates" has been used for almost a year, it will be very confusing to transition to "extensions"
- "extension" is not very specific
- these are not "extensions" per se - they do not augment the capabilities of the runtime in any way, but rather allow to group ops inside a single crate
bartlomieju
reviewed
Apr 25, 2021
hayd
reviewed
Apr 25, 2021
Since not idempotent as of today
rtsmarty
reviewed
Apr 27, 2021
rtsmarty
reviewed
Apr 27, 2021
AaronO
added a commit
to AaronO/deno
that referenced
this pull request
Apr 28, 2021
This implementation is both cleaner and more flexible than the original prototype in denoland#9800
This was referenced Apr 28, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements ideas discussed in #9738, specifically the concept of
JsRuntimeModules which makes modular runtime features plug-n-play.Goals
Reduce complexity in
runtime, make modules self-contained and streamline snapshotting, etc...This should make many parts of
denosimpler and reusable by third-parties and reduce the implicit complexity in bootstrapping JsRuntimes (when snapshotting or not ...).op_cratesshould now be easily usable withoutruntimeSubtasks
JsRuntimeModulefoundations/traits (core/runtime_modules.rs)JsRuntimeinit via modulesop_cratesto be::init() -> JsRuntimeModule(essentially move code from
runtime/ops/*.rstoop_crates/*/lib.rs)include_js_files!()anddeclare_ops!()macrosJsRuntimes & ops to use these new modules)OpMiddlewareOpMetrics(replacingop_metrics)OpTracingmiddleware (--optraceflag)UnstableCheckerinto an OpMiddlewaredeno_runtimeuse JsRuntimeModules ?web_modules()helper function that inits all Web-API modules (url, fetch, ... essentiallyop_cratestoday)--no-snapshotflag to allow running without snapshots (not sure if useful at all, even when debugging, besides optimize(core): move internal js src off heap #9713)Potential Follow-ups
declare_ops!()macrosMultiModuleabstraction, thus reverting Extension to a TraitruntimecliWorkerandWebWorker, making them more reusable and composableWorkerandMainWorkerwithout snapshots, good for debugging and in general snapshots should be optional and viewed as a graceful enhancement (perf boost)