-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: align plugin api with Extension #10427
Conversation
@eliassjogreen Could you merge with master? |
|
Why's that? These are not methods we generally want user code to call. I suppose the distinction is blurred in the case of plugins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @eliassjogreen for giving the plugin API some love.
One possible workaround would be to have |
Continuation on #9850. This pr aligns the plugin api with the new runtime extensions introduced in #9800. I have not yet limited any of the access to the
Extension
struct so currently they are the exact same (Except js, and middleware support which probably would not be needed nor used. Reason for not implementing them is that they need access to theJsRuntime
whichop_open_plugin
does not have). TheExtension
struct should probably be split into a few traits (JsExtension
andMiddlewareExtension
) or a newDynamicExtension
struct could be introduced.cc @crowlKats @AaronO