Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(std/wasi): make implementation details private #8996

Conversation

caspervonb
Copy link
Contributor

This makes the implementation details of the Context class private, making the public interface much more bare-bones and aligns it closer to what Node exposes which is only the exports.

This makes the implementation details of the Context class private,
making the public interface much more bare-bones and aligns it closer to
what Node exposes.
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit ee9c0c8 into denoland:master Jan 5, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
…o#8996)

This makes the implementation details of the Context class private,
making the public interface much more bare-bones and aligns it closer to
what Node exposes.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
This makes the implementation details of the Context class private,
making the public interface much more bare-bones and aligns it closer to
what Node exposes.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
This makes the implementation details of the Context class private,
making the public interface much more bare-bones and aligns it closer to
what Node exposes.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
This makes the implementation details of the Context class private,
making the public interface much more bare-bones and aligns it closer to
what Node exposes.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
This makes the implementation details of the Context class private,
making the public interface much more bare-bones and aligns it closer to
what Node exposes.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
This makes the implementation details of the Context class private,
making the public interface much more bare-bones and aligns it closer to
what Node exposes.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
This makes the implementation details of the Context class private,
making the public interface much more bare-bones and aligns it closer to
what Node exposes.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
This makes the implementation details of the Context class private,
making the public interface much more bare-bones and aligns it closer to
what Node exposes.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
This makes the implementation details of the Context class private,
making the public interface much more bare-bones and aligns it closer to
what Node exposes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants